Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(roi_pointcloud_fusion): add roi scale factor param #10333

Merged
merged 2 commits into from
Mar 26, 2025
+37 −5

fix: missing declare

27ec443
Select commit
Loading
Failed to load commit list.
Merged

fix(roi_pointcloud_fusion): add roi scale factor param #10333

fix: missing declare
27ec443
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Mar 25, 2025 in 43s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (1 file with Complex Conditional)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
geometry.cpp 1 advisory rule 8.82 → 8.41 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Conditional geometry.cpp: isPointInsideRoi

Annotations

Check warning on line 201 in perception/autoware_image_projection_based_fusion/src/utils/geometry.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Conditional 

isPointInsideRoi has 1 complex conditionals with 3 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
View more details on CodeScene Delta Analysis