Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(roi_pointcloud_fusion): merge into pointcloud container #10334

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Mar 25, 2025

Description

  • To add roi_pointcloud_fusion node into /pointcloud_container

Before:

/pointcloud_container
  1  /perception/obstacle_segmentation/crop_box_filter
  2  /perception/occupancy_grid_map/raw_pc_downsample_filter
  4  /perception/object_recognition/detection/centerpoint/lidar_centerpoint
  5  /perception/object_recognition/detection/voxel_grid_downsample_filter
  6  /perception/obstacle_segmentation/common_ground_filter
  7  /perception/occupancy_grid_map/obstacle_pc_downsample_filter
  8  /perception/object_recognition/detection/voxel_based_compare_map_filter
  9  /perception/occupancy_grid_map/occupancy_grid_map_node

After:

/pointcloud_container
  1  /perception/obstacle_segmentation/crop_box_filter
  2  /perception/occupancy_grid_map/raw_pc_downsample_filter
  3  /perception/object_recognition/detection/clustering/roi_cluster/roi_pointcloud_fusion
  4  /perception/object_recognition/detection/centerpoint/lidar_centerpoint
  5  /perception/object_recognition/detection/voxel_grid_downsample_filter
  6  /perception/obstacle_segmentation/common_ground_filter
  7  /perception/occupancy_grid_map/obstacle_pc_downsample_filter
  8  /perception/object_recognition/detection/voxel_based_compare_map_filter
  9  /perception/occupancy_grid_map/occupancy_grid_map_node

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Mar 25, 2025
Copy link

github-actions bot commented Mar 25, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@badai-nguyen badai-nguyen added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 25, 2025
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.92%. Comparing base (dbc5923) to head (359d99e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10334      +/-   ##
==========================================
- Coverage   25.92%   25.92%   -0.01%     
==========================================
  Files        1383     1383              
  Lines      106873   106881       +8     
  Branches    40931    40934       +3     
==========================================
  Hits        27708    27708              
- Misses      76459    76467       +8     
  Partials     2706     2706              
Flag Coverage Δ *Carryforward flag
differential 4.19% <ø> (?)
differential-cuda 2.85% <ø> (?)
total 25.92% <ø> (ø) Carriedforward from dbc5923

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@badai-nguyen badai-nguyen force-pushed the fix/roi_pointcloud_fusion/container branch from f5d5f45 to 359d99e Compare March 25, 2025 04:29
@badai-nguyen badai-nguyen marked this pull request as ready for review March 25, 2025 23:41
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badai-nguyen badai-nguyen merged commit edd2901 into autowarefoundation:main Mar 26, 2025
72 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants