Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(planning_validator): check for sudden shift in planning trajectory #10339

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

mkquda
Copy link
Contributor

@mkquda mkquda commented Mar 25, 2025

Description

There have been reported instances where the planning trajectory experiences a sudden lateral/longitudinal shift, resulting in a sudden steering/deceleration.

edf582f1-ef87-4031-bffe-fa544c0add06

ca87f7df-ad9b-48f1-90e5-66d8869dd44d

This PR adds a feature to planning validator to check for such occurrence by comparing the new trajectory to the previous one and measuring lateral/longitudinal shifts.

Additionally this PR modifies planning_validator paramters to allow for more flexible configuration of the handling method for each check.

To reduce unnecessary jerky motion, this PR also adds the option to perform a soft stop instead of emergency stop for planning validator checks.

Related links

How was this PR tested?

Test using PSIM:

RTC manager panel was used to generate a sudden lateral shift by switching to manual mode in the middle of lane change maneuver. The behavior is shown below:

cap-.2025-03-26-09-02-48.mp4

Rosbag Test using Perception Reproducer:

cap-.2025-03-28-10-10-38.mp4

Degradation Test:

  • TIER IV Internal Evaluator. (Pending)

Notes for reviewers

None.

Interface changes

Complete restructuring of planning_validator parameters.

Effects on system behavior

Planning validator can detect sudden shifts in trajectory and react to avoid sudden steering/acceleration

youtalk and others added 12 commits March 10, 2025 01:47
not sync github-release

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
not sync github-release

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
…on-method

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Mar 25, 2025
Copy link

github-actions bot commented Mar 25, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
@mkquda mkquda marked this pull request as ready for review March 28, 2025 01:33
@mkquda mkquda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 28, 2025
@github-actions github-actions bot removed the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Mar 28, 2025
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

5 participants