fix(control_validator): fix sign miss and add code test #10341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki-takagi-66
requested review from
kyoichi-sugahara,
mkuri,
soblin,
TakaHoribe and
takayuki5168
as code owners
github-actions
bot
added
the
component:control
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
yuki-takagi-66
added
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10341 +/- ##
=======================================
Coverage 25.64% 25.65%
=======================================
Files 1362 1362
Lines 104703 104706 +3
Branches 39824 39822 -2
=======================================
+ Hits 26855 26859 +4
+ Misses 75241 75240 -1
Partials 2607 2607
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yuki-takagi-66
force-pushed
the
takagi/add-acc-validator
branch
from
d681da0 to
b19f4c7
Compare
github-actions
bot
added
the
type:ci
yuki-takagi-66
force-pushed
the
takagi/add-acc-validator
branch
from
b19f4c7 to
f249b27
Compare
github-actions
bot
removed
the
type:ci
kyoichi-sugahara
approved these changes
Mar 26, 2025
yuki-takagi-66
merged commit e048399
into
autowarefoundation:main
34 of 35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix sign miss in #10326
commits/9d2c834fff208d4a977bde96882ad5b6a94b0876
increase cut off velocity
add code tests
Related links
#10326
How was this PR tested?
does not judge as error with current params including stop/start on slope(12.5%)
Screencast from 2025年03月26日 17時24分09秒.webm
detect error if
acc_time_delay: 1.1in simulator_model.param.yamlScreencast from 2025年03月26日 17時24分09秒.webm
tier4 scenario test was passed
https://evaluation.tier4.jp/evaluation/reports/eae98895-960f-5841-9981-afebd1a0553a?project_id=prd_jt
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.