feat(mrm_pull_over_manager): add pull over mrm #5634
Closed
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Mar 25, 2024 in 36s
CodeScene PR Check
✅ Code Health Quality Gates: OK
- Declining Code Health: 3 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
Details
🚩 Declining Code Health (highest to lowest):
- Deep, Nested Complexity mrm_pull_over_manager_core.cpp: get_all_following_and_left_lanelets
- Bumpy Road Ahead emergency_goal_manager_core.cpp: EmergencyGoalManager::callSetMrmRoutePoints
- Bumpy Road Ahead emergency_goal_manager_core.cpp: EmergencyGoalManager::callClearMrmRoute
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Deep, Nested Complexity
get_all_following_and_left_lanelets has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.
Check warning on line 120 in system/emergency_goal_manager/src/emergency_goal_manager_core.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
EmergencyGoalManager::callSetMrmRoutePoints has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check warning on line 149 in system/emergency_goal_manager/src/emergency_goal_manager_core.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
EmergencyGoalManager::callClearMrmRoute has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Loading