Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(map_based_prediction): suppress spell check failure #6403

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Feb 14, 2024

Description

suppress spell check failure for map_based_prediction

  • add routable as ignore word to .cspell-partial.json
  • Sgnal -> Signal
  • additon -> addition

Related links

Tests performed

I check spell check is succeess.

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Feb 14, 2024
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-ohta
Copy link
Contributor Author

h-ohta commented Feb 14, 2024

I added routable to autoware-spell-check-dict.
tier4/autoware-spell-check-dict#654

@ktro2828 ktro2828 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (78eea31) 14.84% compared to head (9890170) 14.84%.
Report is 4 commits behind head on main.

Files Patch % Lines
...based_prediction/src/map_based_prediction_node.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6403   +/-   ##
=======================================
  Coverage   14.84%   14.84%           
=======================================
  Files        1838     1838           
  Lines      126712   126712           
  Branches    37976    37976           
=======================================
  Hits        18816    18816           
  Misses      86649    86649           
  Partials    21247    21247           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.84% <ø> (+<0.01%) ⬆️ Carriedforward from 78eea31

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miursh miursh merged commit 4f0564f into main Feb 14, 2024
@miursh miursh deleted the fix/spell_check_map_based_prediction branch February 14, 2024 16:42
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants