Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(map_based_prediction): suppress spell check failure #6403

Merged
merged 1 commit into from
Feb 14, 2024
Merged

fix(map_based_prediction): suppress spell check failure #6403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .cspell-partial.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@
"perception/bytetrack/lib/**"
],
"ignoreRegExpList": [],
"words": ["dltype", "tvmgen", "quantizer", "imageio", "mimsave"]
"words": ["dltype", "tvmgen", "quantizer", "imageio", "mimsave", "routable"]
}
2 changes: 1 addition & 1 deletion perception/map_based_prediction/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ If there are a reachable crosswalk entry points within the `prediction_time_hori

This module takes into account the corresponding traffic light information.
When RED signal is indicated, we assume the target object will not walk across.
In additon, if the target object is stopping (not moving) against GREEN signal, we assume the target object will not walk across either.
In addition, if the target object is stopping (not moving) against GREEN signal, we assume the target object will not walk across either.
This prediction comes from the assumption that the object should move if the traffic light is green and the object is intended to cross.

<div align="center">
Expand Down
2 changes: 1 addition & 1 deletion perception/map_based_prediction/include/map_based_prediction/map_based_prediction_node.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ class MapBasedPredictionNode : public rclcpp::Node
const PredictedPath & predicted_path, const std::vector<PredictedPath> & predicted_paths);
std::optional<lanelet::Id> getTrafficSignalId(const lanelet::ConstLanelet & way_lanelet);
std::optional<TrafficSignalElement> getTrafficSignalElement(const lanelet::Id & id);
bool calcIntentionToCrossWithTrafficSgnal(
bool calcIntentionToCrossWithTrafficSignal(
const TrackedObject & object, const lanelet::ConstLanelet & crosswalk,
const lanelet::Id & signal_id);

Expand Down
4 changes: 2 additions & 2 deletions perception/map_based_prediction/src/map_based_prediction_node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1240,7 +1240,7 @@ PredictedObject MapBasedPredictionNode::getPredictedObjectAsCrosswalkUser(
for (const auto & crosswalk : crosswalks_) {
const auto crosswalk_signal_id_opt = getTrafficSignalId(crosswalk);
if (crosswalk_signal_id_opt.has_value() && use_crosswalk_signal_) {
if (!calcIntentionToCrossWithTrafficSgnal(
if (!calcIntentionToCrossWithTrafficSignal(
object, crosswalk, crosswalk_signal_id_opt.value())) {
continue;
}
Expand Down Expand Up @@ -2292,7 +2292,7 @@ std::optional<TrafficSignalElement> MapBasedPredictionNode::getTrafficSignalElem
return std::nullopt;
}

bool MapBasedPredictionNode::calcIntentionToCrossWithTrafficSgnal(
bool MapBasedPredictionNode::calcIntentionToCrossWithTrafficSignal(
const TrackedObject & object, const lanelet::ConstLanelet & crosswalk,
const lanelet::Id & signal_id)
{
Expand Down