-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(perception_online_evaluator): add metric_value not only stat (#7100)(#7118) (revert of revert) #7167
Conversation
...on_online_evaluator/include/perception_online_evaluator/perception_online_evaluator_node.hpp
Outdated
Show resolved
Hide resolved
evaluator/perception_online_evaluator/src/perception_online_evaluator_node.cpp
Outdated
Show resolved
Hide resolved
evaluator/perception_online_evaluator/src/perception_online_evaluator_node.cpp
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7167 +/- ##
==========================================
+ Coverage 14.87% 15.58% +0.70%
==========================================
Files 1992 1979 -13
Lines 138800 137069 -1731
Branches 43714 44458 +744
==========================================
+ Hits 20653 21361 +708
+ Misses 95359 92351 -3008
- Partials 22788 23357 +569
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…t only s…" This reverts commit d827b1b.
…e_evaluator/perception_online_evaluator_node.hpp
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
d4edf4c
to
10366f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I confirmed that the following two types of DianosticsStatus are produced by actually running the code.
This PR code works with tier4/driving_log_replayer#467
…)(#7118) (revert of revert) (#7167) * Revert "fix(perception_online_evaluator): revert "add metric_value not only s…" This reverts commit d827b1b. * Update evaluator/perception_online_evaluator/include/perception_online_evaluator/perception_online_evaluator_node.hpp * Update evaluator/perception_online_evaluator/src/perception_online_evaluator_node.cpp * use emplace back Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Kotaro Uetake <60615504+ktro2828@users.noreply.github.com>
this PR need to wait for driving log replayer
Reverts #7118
#7100
Description
Previously, only stat with
max
,mean
, andmin
as keys could be handled in diagnostics, but this PR allowsmetric_value
with a single value.This is to allow only one value to be included in metrics such as object counts, since all stat values are the same, which is redundant.
Tests performed
psim
Effects on system behavior
Not applicable.
Interface changes
no interface changes for autoware.
but the diagnostic key used for tools (driving_log_replayer etc) is chaged
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.