fix(ndt_scan_matcher): fix to pass clang-tidy's check

[SakodaShintaro]

Description

(1)

To avoid warning: function 'callback_sensor_points_main' has cognitive complexity of 26 (threshold 25) [readability-function-cognitive-complexity], I changed from for statement to stl algorithm.

This change was made only to avoid warnings, and it is possible that readability has not improved but has actually decreased. I think it would be reasonable for this pull request to be judged as Reject on this reason. There is a possibility that it is better to properly separate the big function callback_sensor_points_main.

(2)

To solve warning: do not access members of unions; use (boost::)variant instead [cppcoreguidelines-pro-type-union-access], I added // NOLINT to those lines.

Tests performed

logging_simulator works well as before.

Effects on system behavior

There are no effects on system behavior.

Interface changes

There are no interface changes.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[KYabuuchi]

This change was made only to avoid warnings, and it is possible that readability has not improved but has actually decreased. I think it would be reasonable for this pull request to be judged as Reject on this reason.

Honestly, I think the source code has become harder to understand 😢

[SakodaShintaro]

Thank you for your comment.
I will fix this pull request because I found it difficult to read when I read the changes again.

[codecov]

Codecov Report

Attention: Patch coverage is 60.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 23.51%. Comparing base (507e3f4) to head (98b93e7).
Report is 37 commits behind head on main.

Files	Patch %	Lines
...ion/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp	33.33%	8 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #7479       +/-   ##
===========================================
+ Coverage   14.84%   23.51%    +8.66%     
===========================================
  Files        1999       54     -1945     
  Lines      139163     3071   -136092     
  Branches    43716      732    -42984     
===========================================
- Hits        20661      722    -19939     
+ Misses      95731     2288    -93443     
+ Partials    22771       61    -22710     

Flag	Coverage Δ
differential	23.51% <60.00%> (?)
total	?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.