Skip to content

fix(autoware_perception_rviz_plugin): fix duplicateBranch warnings #7695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Jun 26, 2024

Description

This is a fix based on cppcheck duplicateBranch warnings

common/autoware_perception_rviz_plugin/src/object_detection/object_polygon_detail.cpp:529:10: style: inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch]
  } else if (shape_msg.type == Shape::POLYGON) {
         ^
common/autoware_perception_rviz_plugin/src/object_detection/object_polygon_detail.cpp:532:5: note: Found duplicate branches for 'if' and 'else'.
  } else {
    ^
common/autoware_perception_rviz_plugin/src/object_detection/object_polygon_detail.cpp:529:10: note: Found duplicate branches for 'if' and 'else'.
  } else if (shape_msg.type == Shape::POLYGON) {
         ^
common/autoware_perception_rviz_plugin/src/object_detection/object_polygon_detail.cpp:565:10: style: inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch]
  } else if (shape_msg.type == Shape::POLYGON) {
         ^
common/autoware_perception_rviz_plugin/src/object_detection/object_polygon_detail.cpp:568:5: note: Found duplicate branches for 'if' and 'else'.
  } else {
    ^
common/autoware_perception_rviz_plugin/src/object_detection/object_polygon_detail.cpp:565:10: note: Found duplicate branches for 'if' and 'else'.
  } else if (shape_msg.type == Shape::POLYGON) {
         ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
@veqcc veqcc self-assigned this Jun 26, 2024
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Jun 26, 2024
Copy link

github-actions bot commented Jun 26, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@veqcc veqcc added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (3d849e9) to head (d60dd88).
Report is 545 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #7695       +/-   ##
==========================================
- Coverage   15.09%   0.00%   -15.10%     
==========================================
  Files        1967       9     -1958     
  Lines      135941    1017   -134924     
  Branches    42122     104    -42018     
==========================================
- Hits        20520       0    -20520     
+ Misses      92700    1017    -91683     
+ Partials    22721       0    -22721     
Flag Coverage Δ
differential 0.00% <ø> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@veqcc veqcc merged commit 3e07609 into autowarefoundation:main Jul 1, 2024
28 of 30 checks passed
@veqcc veqcc deleted the fix_duplicate_branch branch July 1, 2024 09:23
mitukou1109 pushed a commit to mitukou1109/autoware_universe that referenced this pull request Jul 2, 2024
…utowarefoundation#7695)

* fix(autoware_perception_rviz_plugin): fix duplicateBranch warnings

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
…utowarefoundation#7695)

* fix(autoware_perception_rviz_plugin): fix duplicateBranch warnings

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
…utowarefoundation#7695)

* fix(autoware_perception_rviz_plugin): fix duplicateBranch warnings

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…7695)

* fix(autoware_perception_rviz_plugin): fix duplicateBranch warnings

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants