fix(autoware_joy_controller): add virtual destructor to autoware_joy_controller #7760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…controller Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
yhisaki
requested review from
rej55,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168 and
tkimura4
as code owners
github-actions
bot
added
the
component:control
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
yhisaki
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7760 +/- ##
==========================================
- Coverage 15.09% 0.00% -15.10%
==========================================
Files 1967 40 -1927
Lines 135941 2156 -133785
Branches 42122 127 -41995
==========================================
- Hits 20520 0 -20520
+ Misses 92700 2156 -90544
+ Partials 22721 0 -22721
☔ View full report in Codecov by Sentry. |
takayuki5168
approved these changes
Jul 1, 2024
mitukou1109
pushed a commit
to mitukou1109/autoware_universe
that referenced
this pull request
Jul 2, 2024
…controller (autowarefoundation#7760) Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
palas21
pushed a commit
to palas21/autoware.universe
that referenced
this pull request
Jul 12, 2024
…controller (autowarefoundation#7760) Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel
pushed a commit
to tby-udel/autoware.universe
that referenced
this pull request
Jul 14, 2024
…controller (autowarefoundation#7760) Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…controller (#7760) Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related links
https://stackoverflow.com/questions/461203/when-to-use-virtual-destructors
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.