-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_behavior_path_planner): remove max_module_size param #7764
Merged
kyoichi-sugahara
merged 3 commits into
autowarefoundation:main
from
kyoichi-sugahara:feat/max_module_size
Jul 3, 2024
Merged
feat(autoware_behavior_path_planner): remove max_module_size param #7764
kyoichi-sugahara
merged 3 commits into
autowarefoundation:main
from
kyoichi-sugahara:feat/max_module_size
Jul 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The max_module_size param has been removed from the behavior_path_planner scene_module_manager.param.yaml file. This param was unnecessary and has been removed to simplify the configuration. Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Merged
5 tasks
maxime-clem
approved these changes
Jul 1, 2024
satoshi-ota
approved these changes
Jul 1, 2024
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7764 +/- ##
==========================================
- Coverage 15.09% 13.33% -1.76%
==========================================
Files 1967 525 -1442
Lines 135941 49076 -86865
Branches 42122 11916 -30206
==========================================
- Hits 20520 6546 -13974
+ Misses 92700 41574 -51126
+ Partials 22721 956 -21765
☔ View full report in Codecov by Sentry. |
1069e18
into
autowarefoundation:main
32 of 34 checks passed
palas21
pushed a commit
to palas21/autoware.universe
that referenced
this pull request
Jul 12, 2024
…utowarefoundation#7764) * feat(behavior_path_planner): remove max_module_size param The max_module_size param has been removed from the behavior_path_planner scene_module_manager.param.yaml file. This param was unnecessary and has been removed to simplify the configuration. Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel
pushed a commit
to tby-udel/autoware.universe
that referenced
this pull request
Jul 14, 2024
…utowarefoundation#7764) * feat(behavior_path_planner): remove max_module_size param The max_module_size param has been removed from the behavior_path_planner scene_module_manager.param.yaml file. This param was unnecessary and has been removed to simplify the configuration. Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…7764) * feat(behavior_path_planner): remove max_module_size param The max_module_size param has been removed from the behavior_path_planner scene_module_manager.param.yaml file. This param was unnecessary and has been removed to simplify the configuration. Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Ariiees
pushed a commit
to Ariiees/autoware.universe
that referenced
this pull request
Jul 22, 2024
…utowarefoundation#7764) * feat(behavior_path_planner): remove max_module_size param The max_module_size param has been removed from the behavior_path_planner scene_module_manager.param.yaml file. This param was unnecessary and has been removed to simplify the configuration. Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
k-hazama-esol
pushed a commit
to tier4/autoware_universe
that referenced
this pull request
Mar 25, 2025
…utowarefoundation#7764) * feat(behavior_path_planner): remove max_module_size param The max_module_size param has been removed from the behavior_path_planner scene_module_manager.param.yaml file. This param was unnecessary and has been removed to simplify the configuration. Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
TomohitoAndo
pushed a commit
to tier4/autoware_universe
that referenced
this pull request
Apr 9, 2025
…endent slots (autowarefoundation#8117, autowarefoundation#7881, autowarefoundation#7764) (#1926) * feat(autoware_behavior_path_planner): remove max_module_size param (autowarefoundation#7764) * feat(behavior_path_planner): remove max_module_size param The max_module_size param has been removed from the behavior_path_planner scene_module_manager.param.yaml file. This param was unnecessary and has been removed to simplify the configuration. Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * feat(autoware_behavior_path_planner): prevent infinite loop in approving scene module process (autowarefoundation#7881) * prevent infinite loop Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * calculate max_iteration_num from number of scene modules Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add doxygen explanation for calculateMaxIterationNum Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * feat(behavior_path _planner): divide planner manager modules into dependent slots (autowarefoundation#8117) Signed-off-by: k-hazama-esol <k-hazama@esol.co.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Signed-off-by: k-hazama-esol <k-hazama@esol.co.jp> Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: Mamoru Sobue <hilo.soblin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I understand that
max_module_size
was introduced as a parameter based on the assumption that a scene module might need to be launched multiple times simultaneously.However, currently there are no such use cases in reality.
The unnecessary existence of common parameters for scene modules could become a barrier when creating new scene modules. Therefore, I propose to remove it in this PR.
In this PR, I'm implementing a function that determines it's impossible to register a module if a scene module with the same name is already registered.
Related links
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.