Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_behavior_path_planner): remove max_module_size param #7764

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Jul 1, 2024

Description

I understand that max_module_size was introduced as a parameter based on the assumption that a scene module might need to be launched multiple times simultaneously.
However, currently there are no such use cases in reality.

The unnecessary existence of common parameters for scene modules could become a barrier when creating new scene modules. Therefore, I propose to remove it in this PR.

In this PR, I'm implementing a function that determines it's impossible to register a module if a scene module with the same name is already registered.

  /**
   * Determine if a new module can be launched. It ensures that only one instance of a particular
   * scene module type is registered at a time.
   *
   * When this returns true:
   * - A new instance of the scene module can be launched.
   * - No other instance of the same name of scene module is currently active or registered.
   *
   */
  bool canLaunchNewModule() const { return observers_.empty(); }

Related links

⚠️ Please approve this PR at first.

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

The max_module_size param has been removed from the behavior_path_planner scene_module_manager.param.yaml file. This param was unnecessary and has been removed to simplify the configuration.

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jul 1, 2024
Copy link

github-actions bot commented Jul 1, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 1, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.33%. Comparing base (3d849e9) to head (1c73e93).
Report is 572 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7764      +/-   ##
==========================================
- Coverage   15.09%   13.33%   -1.76%     
==========================================
  Files        1967      525    -1442     
  Lines      135941    49076   -86865     
  Branches    42122    11916   -30206     
==========================================
- Hits        20520     6546   -13974     
+ Misses      92700    41574   -51126     
+ Partials    22721      956   -21765     
Flag Coverage Δ
differential 13.33% <ø> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara kyoichi-sugahara merged commit 1069e18 into autowarefoundation:main Jul 3, 2024
32 of 34 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the feat/max_module_size branch July 3, 2024 00:46
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
…utowarefoundation#7764)

* feat(behavior_path_planner): remove max_module_size param

The max_module_size param has been removed from the behavior_path_planner scene_module_manager.param.yaml file. This param was unnecessary and has been removed to simplify the configuration.

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
…utowarefoundation#7764)

* feat(behavior_path_planner): remove max_module_size param

The max_module_size param has been removed from the behavior_path_planner scene_module_manager.param.yaml file. This param was unnecessary and has been removed to simplify the configuration.

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…7764)

* feat(behavior_path_planner): remove max_module_size param

The max_module_size param has been removed from the behavior_path_planner scene_module_manager.param.yaml file. This param was unnecessary and has been removed to simplify the configuration.

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
…utowarefoundation#7764)

* feat(behavior_path_planner): remove max_module_size param

The max_module_size param has been removed from the behavior_path_planner scene_module_manager.param.yaml file. This param was unnecessary and has been removed to simplify the configuration.

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
k-hazama-esol pushed a commit to tier4/autoware_universe that referenced this pull request Mar 25, 2025
…utowarefoundation#7764)

* feat(behavior_path_planner): remove max_module_size param

The max_module_size param has been removed from the behavior_path_planner scene_module_manager.param.yaml file. This param was unnecessary and has been removed to simplify the configuration.

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
TomohitoAndo pushed a commit to tier4/autoware_universe that referenced this pull request Apr 9, 2025
…endent slots (autowarefoundation#8117, autowarefoundation#7881, autowarefoundation#7764) (#1926)

* feat(autoware_behavior_path_planner): remove max_module_size param (autowarefoundation#7764)

* feat(behavior_path_planner): remove max_module_size param

The max_module_size param has been removed from the behavior_path_planner scene_module_manager.param.yaml file. This param was unnecessary and has been removed to simplify the configuration.

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* feat(autoware_behavior_path_planner): prevent infinite loop in approving scene module process (autowarefoundation#7881)

* prevent infinite loop

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* calculate max_iteration_num from number of scene modules

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* add doxygen explanation for calculateMaxIterationNum

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* feat(behavior_path _planner): divide planner manager modules into dependent slots (autowarefoundation#8117)

Signed-off-by: k-hazama-esol <k-hazama@esol.co.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: k-hazama-esol <k-hazama@esol.co.jp>
Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: Mamoru Sobue <hilo.soblin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants