feat: add handle angle scale property to signal display #7774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KhalilSelyan
added
the
type:ui-ux
github-actions
bot
added
the
component:common
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
3 tasks
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
…r msg_ptr instead of float value Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
github-actions
bot
added
the
type:documentation
added 2 commits
July 1, 2024 19:17
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
MertClk
approved these changes
Jul 1, 2024
|
LGTM |
MertClk
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7774 +/- ##
==========================================
- Coverage 28.40% 28.40% -0.01%
==========================================
Files 1585 1585
Lines 115451 115461 +10
Branches 49231 49233 +2
==========================================
Hits 32794 32794
- Misses 73707 73717 +10
Partials 8950 8950
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
|
mitukou1109
pushed a commit
to mitukou1109/autoware.universe
that referenced
this pull request
Jul 2, 2024
…dation#7774) * feat: add handle angle scale property to signal display * fix: set default steering angle to 0.0° when not received Signed-off-by: KhalilSelyan <khalil@leodrive.ai> * fix: set default steering angle to N/A when not received and check for msg_ptr instead of float value Signed-off-by: KhalilSelyan <khalil@leodrive.ai> * chore: update steering wheel font size and wheel icon center is bigger Signed-off-by: KhalilSelyan <khalil@leodrive.ai> * chore: update steering wheel display to center the steering angle text Signed-off-by: KhalilSelyan <khalil@leodrive.ai> * chore: align steering angle text in both negative and positive cases Signed-off-by: KhalilSelyan <khalil@leodrive.ai> --------- Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
palas21
pushed a commit
to palas21/autoware.universe
that referenced
this pull request
Jul 12, 2024
…dation#7774) * feat: add handle angle scale property to signal display * fix: set default steering angle to 0.0° when not received Signed-off-by: KhalilSelyan <khalil@leodrive.ai> * fix: set default steering angle to N/A when not received and check for msg_ptr instead of float value Signed-off-by: KhalilSelyan <khalil@leodrive.ai> * chore: update steering wheel font size and wheel icon center is bigger Signed-off-by: KhalilSelyan <khalil@leodrive.ai> * chore: update steering wheel display to center the steering angle text Signed-off-by: KhalilSelyan <khalil@leodrive.ai> * chore: align steering angle text in both negative and positive cases Signed-off-by: KhalilSelyan <khalil@leodrive.ai> --------- Signed-off-by: KhalilSelyan <khalil@leodrive.ai> Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel
pushed a commit
to tby-udel/autoware.universe
that referenced
this pull request
Jul 14, 2024
…dation#7774) * feat: add handle angle scale property to signal display * fix: set default steering angle to 0.0° when not received Signed-off-by: KhalilSelyan <khalil@leodrive.ai> * fix: set default steering angle to N/A when not received and check for msg_ptr instead of float value Signed-off-by: KhalilSelyan <khalil@leodrive.ai> * chore: update steering wheel font size and wheel icon center is bigger Signed-off-by: KhalilSelyan <khalil@leodrive.ai> * chore: update steering wheel display to center the steering angle text Signed-off-by: KhalilSelyan <khalil@leodrive.ai> * chore: align steering angle text in both negative and positive cases Signed-off-by: KhalilSelyan <khalil@leodrive.ai> --------- Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
KhalilSelyan
added a commit
that referenced
this pull request
Jul 22, 2024
* feat: add handle angle scale property to signal display * fix: set default steering angle to 0.0° when not received Signed-off-by: KhalilSelyan <khalil@leodrive.ai> * fix: set default steering angle to N/A when not received and check for msg_ptr instead of float value Signed-off-by: KhalilSelyan <khalil@leodrive.ai> * chore: update steering wheel font size and wheel icon center is bigger Signed-off-by: KhalilSelyan <khalil@leodrive.ai> * chore: update steering wheel display to center the steering angle text Signed-off-by: KhalilSelyan <khalil@leodrive.ai> * chore: align steering angle text in both negative and positive cases Signed-off-by: KhalilSelyan <khalil@leodrive.ai> --------- Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move a hard coded scale value to editable rviz property
Parent Issue:
How was this PR tested?
Checked both old and new overlay for confirming values
Effects on system behavior
None.