-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(pure_pursuit): rework parameters #8196
base: main
Are you sure you want to change the base?
refactor(pure_pursuit): rework parameters #8196
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8196 +/- ##
==========================================
- Coverage 25.01% 23.67% -1.34%
==========================================
Files 1322 1396 +74
Lines 98044 101179 +3135
Branches 37820 38368 +548
==========================================
- Hits 24521 23951 -570
- Misses 71044 74791 +3747
+ Partials 2479 2437 -42
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: batuhanbeytekin <batuhanbeytekin@gmail.com>
c14c84c
to
225a130
Compare
I was testing this locally by running the local launch file, but there seems to be a issue with package names. |
Thank you for your feedback |
This pull request has been automatically marked as stale because it has not had recent activity. |
@mitsudome-r To test the launch file again. |
This pull request has been automatically marked as stale because it has not had recent activity. |
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371
Tests performed
Package built and launch locally.
Effects on system behavior
More reliable and faster parameter configuration file creation.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.