Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pure_pursuit): rework parameters #8196

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

batuhanbeytekin
Copy link
Member

Description

Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371

Tests performed

Package built and launch locally.

Effects on system behavior

More reliable and faster parameter configuration file creation.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@batuhanbeytekin batuhanbeytekin added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) DevOps Dojo: ROS Node Conf Related to Open AD Kit WG run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Jul 25, 2024
@batuhanbeytekin batuhanbeytekin self-assigned this Jul 25, 2024
Copy link

github-actions bot commented Jul 25, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@github-actions github-actions bot added component:control Vehicle control algorithms and mechanisms. (auto-assigned) and removed component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.67%. Comparing base (8213bdf) to head (e9500ba).
Report is 1224 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8196      +/-   ##
==========================================
- Coverage   25.01%   23.67%   -1.34%     
==========================================
  Files        1322     1396      +74     
  Lines       98044   101179    +3135     
  Branches    37820    38368     +548     
==========================================
- Hits        24521    23951     -570     
- Misses      71044    74791    +3747     
+ Partials     2479     2437      -42     
Flag Coverage Δ *Carryforward flag
differential 32.35% <ø> (?)
total 23.75% <ø> (-1.26%) ⬇️ Carriedforward from c5e6655

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

batuhanbeytekin and others added 2 commits August 12, 2024 19:55
Signed-off-by: batuhanbeytekin <batuhanbeytekin@gmail.com>
@oguzkaganozt oguzkaganozt force-pushed the refactor/pure_pursuit branch from c14c84c to 225a130 Compare August 12, 2024 16:55
@mitsudome-r
Copy link
Member

I was testing this locally by running the local launch file, but there seems to be a issue with package names.
They are fixed in this PR.
https://github.com/autowarefoundation/autoware.universe/pull/8687/files

@batuhanbeytekin
Copy link
Member Author

I was testing this locally by running the local launch file, but there seems to be a issue with package names. They are fixed in this PR. https://github.com/autowarefoundation/autoware.universe/pull/8687/files

Thank you for your feedback

@mitsudome-r mitsudome-r enabled auto-merge (squash) September 5, 2024 14:08
Copy link

stale bot commented Nov 4, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Nov 4, 2024
@mitsudome-r
Copy link
Member

@mitsudome-r To test the launch file again.

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Jan 14, 2025
Copy link

stale bot commented Mar 15, 2025

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) DevOps Dojo: ROS Node Conf Related to Open AD Kit WG run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) status:stale Inactive or outdated issues. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants