-
Notifications
You must be signed in to change notification settings - Fork 740
refactor(external_cmd_selector): rework parameters #8198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(external_cmd_selector): rework parameters #8198
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8198 +/- ##
==========================================
- Coverage 23.90% 23.90% -0.01%
==========================================
Files 1380 1380
Lines 101770 101747 -23
Branches 38731 38713 -18
==========================================
- Hits 24332 24323 -9
+ Misses 74992 74918 -74
- Partials 2446 2506 +60
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
||
## Parameters | ||
|
||
{{json_to_markdown("/control/autoware_external_cmd_selector/schema/external_cmd_selector.schema.json")}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generated documentation page is complaining about the path for json file.
The path for this function should be the relative path from the root directory so please remove the first '/'.
{{json_to_markdown("/control/autoware_external_cmd_selector/schema/external_cmd_selector.schema.json")}} | |
{{json_to_markdown("control/autoware_external_cmd_selector/schema/external_cmd_selector.schema.json")}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@batuhanbeytekin It seems like you resolved the conversation, but it seems like the issue exists. Could you remove the first /
in the path?
1e1581a
to
cad7c3a
Compare
6626ba9
to
9ee12f3
Compare
8af09a0
to
8fdede9
Compare
8fdede9
to
030ad68
Compare
030ad68
to
f56bd00
Compare
ab4f44d
to
844b46b
Compare
Signed-off-by: Batuhan Beytekin <batuhanbeytekin@gmail.com>
844b46b
to
dc9fd4b
Compare
Hi @TakaHoribe, @rej55, @satoshi-ota, @shmpwk, @taikitanaka3, @takayuki5168, @tkimura4, One approval is needed to merge this PR. Could you please review it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371
Tests performed
Package built and launch locally.
Effects on system behavior
More reliable and faster parameter configuration file creation.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.