Skip to content

refactor(external_cmd_selector): rework parameters #8198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

batuhanbeytekin
Copy link
Member

Description

Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371

Tests performed

Package built and launch locally.

Effects on system behavior

More reliable and faster parameter configuration file creation.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@batuhanbeytekin batuhanbeytekin added type:documentation Creating or refining documentation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) DevOps Dojo: ROS Node Conf Related to Open AD Kit WG run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Jul 25, 2024
@batuhanbeytekin batuhanbeytekin self-assigned this Jul 25, 2024
Copy link

github-actions bot commented Jul 25, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

github-actions bot commented Jul 25, 2024

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.90%. Comparing base (a742e82) to head (59f844a).
Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8198      +/-   ##
==========================================
- Coverage   23.90%   23.90%   -0.01%     
==========================================
  Files        1380     1380              
  Lines      101770   101747      -23     
  Branches    38731    38713      -18     
==========================================
- Hits        24332    24323       -9     
+ Misses      74992    74918      -74     
- Partials     2446     2506      +60     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 23.90% <ø> (-0.01%) ⬇️ Carriedforward from 5e400de

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


## Parameters

{{json_to_markdown("/control/autoware_external_cmd_selector/schema/external_cmd_selector.schema.json")}}
Copy link
Member

@mitsudome-r mitsudome-r Aug 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated documentation page is complaining about the path for json file.
image

The path for this function should be the relative path from the root directory so please remove the first '/'.

Suggested change
{{json_to_markdown("/control/autoware_external_cmd_selector/schema/external_cmd_selector.schema.json")}}
{{json_to_markdown("control/autoware_external_cmd_selector/schema/external_cmd_selector.schema.json")}}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@batuhanbeytekin It seems like you resolved the conversation, but it seems like the issue exists. Could you remove the first / in the path?

@batuhanbeytekin batuhanbeytekin force-pushed the refactor/external_cmd_selector branch from 1e1581a to cad7c3a Compare August 2, 2024 12:35
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Aug 2, 2024
@github-actions github-actions bot removed type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Aug 2, 2024
@batuhanbeytekin batuhanbeytekin force-pushed the refactor/external_cmd_selector branch from 6626ba9 to 9ee12f3 Compare August 2, 2024 12:44
@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Aug 2, 2024
@batuhanbeytekin batuhanbeytekin force-pushed the refactor/external_cmd_selector branch from 8af09a0 to 8fdede9 Compare August 2, 2024 12:54
@github-actions github-actions bot removed component:planning Route planning, decision-making, and navigation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Aug 2, 2024
@oguzkaganozt oguzkaganozt force-pushed the refactor/external_cmd_selector branch from 8fdede9 to 030ad68 Compare August 12, 2024 16:57
@batuhanbeytekin batuhanbeytekin force-pushed the refactor/external_cmd_selector branch from 030ad68 to f56bd00 Compare August 14, 2024 11:06
@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Aug 14, 2024
@batuhanbeytekin batuhanbeytekin force-pushed the refactor/external_cmd_selector branch 3 times, most recently from ab4f44d to 844b46b Compare August 14, 2024 11:12
Signed-off-by: Batuhan Beytekin <batuhanbeytekin@gmail.com>
@batuhanbeytekin batuhanbeytekin force-pushed the refactor/external_cmd_selector branch from 844b46b to dc9fd4b Compare August 14, 2024 11:12
@github-actions github-actions bot removed component:planning Route planning, decision-making, and navigation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Aug 14, 2024
@batuhanbeytekin
Copy link
Member Author

Hi @TakaHoribe, @rej55, @satoshi-ota, @shmpwk, @taikitanaka3, @takayuki5168, @tkimura4,

One approval is needed to merge this PR. Could you please review it?

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@batuhanbeytekin batuhanbeytekin merged commit 2719e23 into autowarefoundation:main Aug 16, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) DevOps Dojo: ROS Node Conf Related to Open AD Kit WG run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants