-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(autoware_velocity_smoother): rework parameters #8298
base: main
Are you sure you want to change the base?
refactor(autoware_velocity_smoother): rework parameters #8298
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-8298/ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8298 +/- ##
==========================================
- Coverage 26.16% 26.14% -0.02%
==========================================
Files 1302 1306 +4
Lines 96917 96964 +47
Branches 39150 39152 +2
==========================================
Hits 25354 25354
- Misses 68900 68947 +47
Partials 2663 2663
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
planning/autoware_velocity_smoother/schema/default_comman.schema.json
Outdated
Show resolved
Hide resolved
2df9f45
to
702dcaa
Compare
9a9e332
to
fe6045b
Compare
Hi @TakaHoribe, @go-sakayori, @mkuri, @rej55, @satoshi-ota, |
ego_nearest_dist_threshold: 0.3 # threshold to find the nearest point on the trajectory [m] | ||
ego_nearest_yaw_threshold: 1.046 # threshold to find the nearest point on the trajectory [rad] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to split these two parameters as default_nearest_search.param.yaml
under config folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These parameters are meant to be managed as common parameter among different nodes and is better to be managed as a separate file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to split these two parameters as
default_nearest_search.param.yaml
under config folder?
I will make the necessary updates as you said. Thanks for your feedback.
fe6045b
to
8f849ac
Compare
curvature_calculation_distance: 5.0 # distance of points while curvature is calculating for the steer rate and lateral acceleration limit [m] | ||
ego_nearest_dist_threshold: 0.3 # threshold to find the nearest point on the trajectory [m] | ||
ego_nearest_yaw_threshold: 1.046 # threshold to find the nearest point on the trajectory [rad] | ||
algorithm_type: "JerkFiltered" # algorithm type for velocity smoother. "JerkFiltered" or "L2" or "Linf" or "Analytical" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you change this to the following code so that the argument passed to the launch file is used instead?
algorithm_type: "JerkFiltered" # algorithm type for velocity smoother. "JerkFiltered" or "L2" or "Linf" or "Analytical" | |
algorithm_type: $(var velocity_smoother_type) # algorithm type for velocity smoother. "JerkFiltered" or "L2" or "Linf" or "Analytical" |
e67438b
to
847885a
Compare
Signed-off-by: batuhanbeytekin <batuhanbeytekin@gmail.com>
Signed-off-by: batuhanbeytekin <batuhanbeytekin@gmail.com>
Signed-off-by: batuhanbeytekin <batuhanbeytekin@gmail.com>
Signed-off-by: batuhanbeytekin <batuhanbeytekin@gmail.com>
8a3d44f
to
a060a63
Compare
This pull request has been automatically marked as stale because it has not had recent activity. |
@oguzkaganozt We should have someone to take over this PR. |
This pull request has been automatically marked as stale because it has not had recent activity. |
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371
Tests performed
Package built and launch locally.
Effects on system behavior
More reliable and faster parameter configuration file creation.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.