feat(raw_vehicle_cmd_converter): add vehicle adaptor #8782
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
Change in average Code Health of affected files: -0.08 (8.27 -> 8.19)
- Declining Code Health: 1 findings(s) 🚩
Details
🚩 Declining Code Health (highest to lowest):
- Complex Conditional node.cpp: RawVehicleCommandConverterNode::publishActuationCmd
Annotations
Check notice on line 204 in vehicle/autoware_raw_vehicle_cmd_converter/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Complex Method
RawVehicleCommandConverterNode::publishActuationCmd increases in cyclomatic complexity from 17 to 24, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 125 in vehicle/autoware_raw_vehicle_cmd_converter/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Complex Method
RawVehicleCommandConverterNode::RawVehicleCommandConverterNode increases in cyclomatic complexity from 17 to 18, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 132 in vehicle/autoware_raw_vehicle_cmd_converter/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Conditional
RawVehicleCommandConverterNode::publishActuationCmd increases from 1 complex conditionals with 2 branches to 2 complex conditionals with 4 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check notice on line 204 in vehicle/autoware_raw_vehicle_cmd_converter/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Bumpy Road Ahead
RawVehicleCommandConverterNode::publishActuationCmd increases from 2 to 3 logical blocks with deeply nested code, threshold is one single block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check notice on line 1 in vehicle/autoware_raw_vehicle_cmd_converter/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 6.50 to 7.38, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.