-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shift_decider): integrate generate_parameter_library #8871
base: main
Are you sure you want to change the base?
feat(shift_decider): integrate generate_parameter_library #8871
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request has been automatically marked as stale because it has not had recent activity. |
Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
58cff32
to
046c7f3
Compare
@mitukou1109 @satoshi-ota @takayuki5168 The PR is approved. Do you have any concerns with merging this PR? |
@satoshi-ota |
@mitsudome-r No. I can merge this. |
I guess this needs approval of @TakaHoribe or @takayuki5168. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8871 +/- ##
==========================================
- Coverage 29.44% 29.44% -0.01%
==========================================
Files 1444 1444
Lines 108617 108624 +7
Branches 42425 42428 +3
==========================================
Hits 31983 31983
- Misses 73547 73554 +7
Partials 3087 3087
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This pull request has been automatically marked as stale because it has not had recent activity. |
Description
This PR enables shift_decider to handle parameters using generate_parameter_library.
How was this PR tested?
Psim
Evaluator: https://evaluation.tier4.jp/evaluation/reports/525f802a-3996-5dc5-a92b-c17d9b230e53?project_id=prd_jt
Notes for reviewers
The node
shift_decider
does not have dynamic parameters.Interface changes
None.
Effects on system behavior
None.