Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shift_decider): integrate generate_parameter_library #8871

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mitukou1109
Copy link
Contributor

@mitukou1109 mitukou1109 commented Sep 13, 2024

Description

This PR enables shift_decider to handle parameters using generate_parameter_library.

How was this PR tested?

Psim

  • errors occur if any parameters are missing in the config file in autoware_launch

Evaluator: https://evaluation.tier4.jp/evaluation/reports/525f802a-3996-5dc5-a92b-c17d9b230e53?project_id=prd_jt

Notes for reviewers

The node shift_decider does not have dynamic parameters.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Sep 13, 2024
Copy link

github-actions bot commented Sep 13, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 17, 2024
Copy link

stale bot commented Nov 16, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Nov 16, 2024
Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
@xmfcx xmfcx force-pushed the feat/shift_decider_param_lib branch from 58cff32 to 046c7f3 Compare January 14, 2025 07:54
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Jan 14, 2025
@mitsudome-r
Copy link
Member

@mitukou1109 @satoshi-ota @takayuki5168 The PR is approved. Do you have any concerns with merging this PR?

@takayuki5168
Copy link
Contributor

@satoshi-ota
Same for #8826 (comment)

@satoshi-ota
Copy link
Contributor

@mitsudome-r No. I can merge this.

@satoshi-ota
Copy link
Contributor

I guess this needs approval of @TakaHoribe or @takayuki5168.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 29.44%. Comparing base (0715615) to head (046c7f3).
Report is 315 commits behind head on main.

Files with missing lines Patch % Lines
...oware_shift_decider/src/autoware_shift_decider.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8871      +/-   ##
==========================================
- Coverage   29.44%   29.44%   -0.01%     
==========================================
  Files        1444     1444              
  Lines      108617   108624       +7     
  Branches    42425    42428       +3     
==========================================
  Hits        31983    31983              
- Misses      73547    73554       +7     
  Partials     3087     3087              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 29.44% <ø> (+<0.01%) ⬆️ Carriedforward from 0715615

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

stale bot commented Mar 16, 2025

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) status:stale Inactive or outdated issues. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants