Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_map_based_prediction): find side lanelet of the next current lanelet #9095

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

feat: find side lanelet of the next current lanelet

f6a32e2
Select commit
Loading
Failed to load commit list.
Draft

feat(autoware_map_based_prediction): find side lanelet of the next current lanelet #9095

feat: find side lanelet of the next current lanelet
f6a32e2
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Oct 28, 2024 in 42s

CodeScene PR Check

Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.01 (2.43 -> 2.42)

  • Declining Code Health: 1 findings(s) 🚩

  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method map_based_prediction_node.cpp: MapBasedPredictionNode::getPredictedReferencePath 🔥

Annotations

Check notice on line 1 in perception/autoware_map_based_prediction/src/map_based_prediction_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Lines of Code in a Single File

The lines of code increases from 2135 to 2143, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.

Check warning on line 1974 in perception/autoware_map_based_prediction/src/map_based_prediction_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

MapBasedPredictionNode::getPredictedReferencePath increases in cyclomatic complexity from 28 to 31, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 1974 in perception/autoware_map_based_prediction/src/map_based_prediction_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Bumpy Road Ahead

MapBasedPredictionNode::getPredictedReferencePath increases from 3 to 4 logical blocks with deeply nested code, threshold is one single block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check notice on line 1 in perception/autoware_map_based_prediction/src/map_based_prediction_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Overall Code Complexity

The mean cyclomatic complexity increases from 7.36 to 7.41, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.