Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lanelet_filter): add crosswalk for lanelet filter #9243

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2

fix(lanelet_filter): add crosswalk lanelet filter

d56287d
Select commit
Loading
Failed to load commit list.
Draft

fix(lanelet_filter): add crosswalk for lanelet filter #9243

fix(lanelet_filter): add crosswalk lanelet filter
d56287d
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Nov 6, 2024 in 51s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.12 (7.67 -> 7.55)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Conditional lanelet_filter.cpp: ObjectLaneletFilterNode::getIntersectedLanelets

Annotations

Check warning on line 265 in perception/autoware_detected_object_validation/src/lanelet_filter/lanelet_filter.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Conditional 

ObjectLaneletFilterNode::getIntersectedLanelets increases from 1 complex conditionals with 2 branches to 1 complex conditionals with 3 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.

Check notice on line 1 in perception/autoware_detected_object_validation/src/lanelet_filter/lanelet_filter.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Overall Code Complexity 

The mean cyclomatic complexity increases from 4.18 to 4.27, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
View more details on CodeScene Delta Analysis