Skip to content

feat(autoware_bytetrack3d): add new 3d multi-object tracking algorithm #9298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

fix: remove unnecessary packages

a31a7d8
Select commit
Loading
Failed to load commit list.
Draft

feat(autoware_bytetrack3d): add new 3d multi-object tracking algorithm #9298

fix: remove unnecessary packages
a31a7d8
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Nov 26, 2024 in 45s

CodeScene PR Check

Code Health Quality Gates: FAILED

Code Health of new files: 7.70

  • Declining Code Health: 31 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Brain Method utils.cpp: ByteTracker::lapjv
  • Bumpy Road Ahead byte_tracker.cpp: ByteTracker::update
  • Complex Method byte_tracker.cpp: ByteTracker::update
  • Complex Method utils.cpp: ByteTracker::lapjv
  • Bumpy Road Ahead utils.cpp: ByteTracker::lapjv
  • Overall Code Complexity lapjv.cpp
  • Deep, Nested Complexity strack.cpp: STrack::yaw_correction
  • Code Duplication utils.cpp
  • Overall Code Complexity utils.cpp
  • Deep, Nested Complexity utils.cpp: ByteTracker::lapjv
  • Complex Method lapjv.cpp: _ccrrt_dense
  • Deep, Nested Complexity lapjv.cpp: _scan_dense
  • Complex Method lapjv.cpp: _carr_dense
  • Missing Arguments Abstractions lapjv.cpp
  • Complex Method strack.cpp: STrack::yaw_correction
  • Bumpy Road Ahead utils.cpp: ByteTracker::remove_duplicate_stracks
  • Deep, Nested Complexity lapjv.cpp: _ccrrt_dense
  • Deep, Nested Complexity lapjv.cpp: _carr_dense
  • Deep, Nested Complexity lapjv.cpp: find_path_dense
  • Complex Method utils.cpp: ByteTracker::remove_duplicate_stracks
  • Bumpy Road Ahead utils.cpp: ByteTracker::linear_assignment
  • Excess Number of Function Arguments utils.cpp: ByteTracker::linear_assignment
  • Bumpy Road Ahead lapjv.cpp: _ccrrt_dense
  • Bumpy Road Ahead lapjv.cpp: _carr_dense
  • Bumpy Road Ahead strack.cpp: STrack::yaw_correction
  • Excess Number of Function Arguments utils.cpp: ByteTracker::lapjv
  • Excess Number of Function Arguments lapjv.cpp: _scan_dense
  • Excess Number of Function Arguments lapjv.cpp: _carr_dense
  • Excess Number of Function Arguments lapjv.cpp: _ca_dense
  • Excess Number of Function Arguments lapjv.cpp: _ccrrt_dense
  • Excess Number of Function Arguments lapjv.cpp: find_path_dense

Annotations

Check warning on line 276 in perception/autoware_bytetrack3D/lib/src/byte_tracker.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

ByteTracker::update has a cyclomatic complexity of 32, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 276 in perception/autoware_bytetrack3D/lib/src/byte_tracker.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

ByteTracker::update has 11 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 107 in perception/autoware_bytetrack3D/lib/src/lapjv.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

_ccrrt_dense has a cyclomatic complexity of 14, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 180 in perception/autoware_bytetrack3D/lib/src/lapjv.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

_carr_dense has a cyclomatic complexity of 12, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 107 in perception/autoware_bytetrack3D/lib/src/lapjv.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

_ccrrt_dense has 4 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 180 in perception/autoware_bytetrack3D/lib/src/lapjv.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

_carr_dense has 4 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 1 in perception/autoware_bytetrack3D/lib/src/lapjv.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Overall Code Complexity

This module has a mean cyclomatic complexity of 7.43 across 7 functions. The mean complexity threshold is 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.

Check warning on line 239 in perception/autoware_bytetrack3D/lib/src/lapjv.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Deep, Nested Complexity

_scan_dense has a nested complexity depth of 5, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.

Check warning on line 107 in perception/autoware_bytetrack3D/lib/src/lapjv.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Deep, Nested Complexity

_ccrrt_dense has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.

Check warning on line 180 in perception/autoware_bytetrack3D/lib/src/lapjv.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Deep, Nested Complexity

_carr_dense has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.

Check warning on line 303 in perception/autoware_bytetrack3D/lib/src/lapjv.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Deep, Nested Complexity

find_path_dense has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.

Check warning on line 1 in perception/autoware_bytetrack3D/lib/src/lapjv.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Missing Arguments Abstractions

The average number of function arguments in this module is 5.57 across 7 functions. The average arguments threshold is 4.00. The functions in this file have too many arguments, indicating a lack of encapsulation or too many responsibilities in the same functions. Avoid adding more.

Check warning on line 107 in perception/autoware_bytetrack3D/lib/src/lapjv.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments

_ccrrt_dense has 6 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.

Check warning on line 180 in perception/autoware_bytetrack3D/lib/src/lapjv.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments

_carr_dense has 7 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.

Check warning on line 239 in perception/autoware_bytetrack3D/lib/src/lapjv.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments

_scan_dense has 9 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.

Check warning on line 303 in perception/autoware_bytetrack3D/lib/src/lapjv.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments

find_path_dense has 6 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.

Check warning on line 339 in perception/autoware_bytetrack3D/lib/src/lapjv.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments

_ca_dense has 7 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.

Check warning on line 371 in perception/autoware_bytetrack3D/lib/src/strack.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

STrack::yaw_correction has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 371 in perception/autoware_bytetrack3D/lib/src/strack.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

STrack::yaw_correction has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 371 in perception/autoware_bytetrack3D/lib/src/strack.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Deep, Nested Complexity

STrack::yaw_correction has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.

Check warning on line 61 in perception/autoware_bytetrack3D/lib/src/utils.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Code Duplication

The module contains 2 functions with similar structure: ByteTracker::joint_stracks,ByteTracker::joint_stracks. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.

Check warning on line 343 in perception/autoware_bytetrack3D/lib/src/utils.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Brain Method

ByteTracker::lapjv is a brain method. A Brain Method -- aka a God Function -- is a large and complex function that centralizes the behavior of a module. Brain Methods are detected using a combination of the following code smells: Deeply Nested Logic + High Cyclomatic Complexity + Many Lines of Code + Many Function Arguments.

Check warning on line 343 in perception/autoware_bytetrack3D/lib/src/utils.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

ByteTracker::lapjv has a cyclomatic complexity of 34, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 142 in perception/autoware_bytetrack3D/lib/src/utils.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

ByteTracker::remove_duplicate_stracks has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 343 in perception/autoware_bytetrack3D/lib/src/utils.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

ByteTracker::lapjv has 11 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.