Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_default_adapi): release adapi v1.6.0 #9704

Conversation

isamu-takagi
Copy link
Contributor

Description

Release AD API v1.6.0. See release notes for details.

Related links

https://autowarefoundation.github.io/autoware-documentation/main/design/autoware-interfaces/ad-api/release/

How was this PR tested?

Door API

  1. Launch planning simulation
  2. Add DoorPanel
  3. Check the doors can be opened/closed in stop mode
  4. Check the doors cannot be opened/closed in other modes.

Route API

  1. Launch planning simulation
  2. Set initialpose and goal
  3. Change to autonomous mode
  4. Check the route cannot be cleared in autonomous mode
  5. Change to stop mode
  6. Check the route can be cleared in stop mode

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@github-actions github-actions bot added component:system System design and integration. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Dec 20, 2024
Copy link

github-actions bot commented Dec 20, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@isamu-takagi isamu-takagi self-assigned this Dec 20, 2024
@isamu-takagi isamu-takagi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 29.03226% with 22 lines in your changes missing coverage. Please review.

Project coverage is 29.89%. Comparing base (3d53032) to head (ccab468).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
system/autoware_default_adapi/src/vehicle_door.cpp 30.43% 16 Missing ⚠️
system/autoware_default_adapi/src/routing.cpp 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9704      +/-   ##
==========================================
+ Coverage   29.66%   29.89%   +0.23%     
==========================================
  Files        1450     1447       -3     
  Lines      108833   107723    -1110     
  Branches    42740    42116     -624     
==========================================
- Hits        32285    32204      -81     
+ Misses      73375    72183    -1192     
- Partials     3173     3336     +163     
Flag Coverage Δ *Carryforward flag
differential 5.75% <29.03%> (?)
total 29.91% <ø> (+0.24%) ⬆️ Carriedforward from 593a78b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isamu-takagi isamu-takagi enabled auto-merge (squash) December 25, 2024 06:10
@isamu-takagi isamu-takagi merged commit e0531b8 into autowarefoundation:main Dec 25, 2024
36 checks passed
@isamu-takagi isamu-takagi deleted the feat/add-adapi-v1.6.0-restrictions branch December 25, 2024 06:31
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Dec 27, 2024
…n#9704)

* feat: reject clearing route during autonomous mode

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: modify check and relay door service

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix door condition

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix error and add option

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* update v1.6.0

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

---------

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants