feat(traffic_light_selector): add new node for traffic light selection #9721
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Feb 9, 2025 in 53s
CodeScene PR Check
Quality Gate Failed
Gates Failed
(1 file with Bumpy Road Ahead)
(2 files with Complex Method)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce critical code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| traffic_light_selector_node.cpp | 1 critical rule | 10.00 → 9.32 | Suppress |
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| traffic_light_selector_node.cpp | 1 advisory rule | 10.00 → 9.32 | Suppress |
| utils.cpp | 1 advisory rule | 10.00 → 9.69 | Suppress |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method traffic_light_selector_node.cpp: TrafficLightSelectorNode::objectsCallback
- Complex Method utils.cpp: isInsideRoughRoi
- Bumpy Road Ahead traffic_light_selector_node.cpp: TrafficLightSelectorNode::objectsCallback
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
TrafficLightSelectorNode::objectsCallback has a cyclomatic complexity of 15, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
TrafficLightSelectorNode::objectsCallback has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check warning on line 44 in perception/autoware_traffic_light_selector/src/utils.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
isInsideRoughRoi has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Loading