Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_perception_launch): add option for new TL detector model #9731

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Dec 23, 2024

Description

Related links

Parent Issue:

How was this PR tested?

I checked new tlr and existing perception pipeline on Evaluator.
https://evaluation.ci.tier4.jp/evaluation/reports/e545bfca-9777-5031-9e92-818bd694e2df?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

fix: tier4 perception launch

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

fix: add multi tlr detector launch

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

fix: tier4 launch

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

fix: tl detector launch

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

fix: data director

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

fix: precision int8

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

chore: revert to fp16

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

feat: remove occlusion and add car ped classification merger

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

fix: launch for multi camera

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

chore: pre-commit

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

fix: update matching score

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

feat: add max_iou_threshold

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

feat: add occlusion unknown classifier

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Dec 23, 2024
Copy link

github-actions bot commented Dec 23, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen badai-nguyen force-pushed the feat/tier4_perception_launch/lanch_new_tl_detector branch from 62f51e4 to 9bf8816 Compare January 6, 2025 08:04
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jan 23, 2025
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen badai-nguyen added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) labels Jan 23, 2025
Copy link

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-9731/
Modified URLs:

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 26.75%. Comparing base (aa19eb9) to head (a752f1e).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...lization/src/traffic_light_roi_visualizer/node.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9731   +/-   ##
=======================================
  Coverage   26.74%   26.75%           
=======================================
  Files        1415     1416    +1     
  Lines      108454   108457    +3     
  Branches    41714    41706    -8     
=======================================
+ Hits        29006    29016   +10     
+ Misses      76575    76569    -6     
+ Partials     2873     2872    -1     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
differential-cuda 0.00% <0.00%> (?)
total 26.75% <ø> (+0.01%) ⬆️ Carriedforward from a8cf827

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badai-nguyen badai-nguyen marked this pull request as ready for review January 23, 2025 05:23
@badai-nguyen badai-nguyen changed the title feat: add traffic_light_detector launch for new TL detector feat(tier4_perception_launch): add option for new TL detector model Jan 23, 2025
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen badai-nguyen marked this pull request as draft January 28, 2025 02:44
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen badai-nguyen marked this pull request as ready for review January 29, 2025 02:52
MasatoSaeki and others added 3 commits February 10, 2025 13:48
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @MasatoSaeki
could you check this comment?

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
@MasatoSaeki MasatoSaeki merged commit d5e923e into autowarefoundation:main Feb 19, 2025
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants