Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(system_monitor): fix bugprone-exception-escape #9781

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on clang-tidy bugprone-exception-escape error.

/home/emb4/autoware/autoware/src/universe/autoware.universe/system/system_monitor/reader/hdd_reader/hdd_reader.cpp:656:5: error: an exception may be thrown in function 'main' which should not throw exceptions [bugprone-exception-escape,-warnings-as-errors]
int main(int argc, char ** argv)
    ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/system/system_monitor/reader/msr_reader/msr_reader.cpp:213:5: error: an exception may be thrown in function 'main' which should not throw exceptions [bugprone-exception-escape,-warnings-as-errors]
int main(int argc, char ** argv)
    ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Dec 25, 2024
Copy link

github-actions bot commented Dec 25, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 25, 2024
@kobayu858 kobayu858 requested a review from veqcc December 25, 2024 06:12
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 58 lines in your changes missing coverage. Please review.

Project coverage is 29.60%. Comparing base (ab845fb) to head (e70bddd).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...em/system_monitor/reader/msr_reader/msr_reader.cpp 0.00% 37 Missing ⚠️
...em/system_monitor/reader/hdd_reader/hdd_reader.cpp 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9781      +/-   ##
==========================================
+ Coverage   29.59%   29.60%   +0.01%     
==========================================
  Files        1451     1450       -1     
  Lines      108919   108446     -473     
  Branches    42597    42536      -61     
==========================================
- Hits        32232    32109     -123     
+ Misses      73589    73179     -410     
- Partials     3098     3158      +60     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 29.62% <ø> (+0.03%) ⬆️ Carriedforward from 90a1bb3

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858
Copy link
Contributor Author

@ito-san @TetsuKawa
Please confirm the PR. Thank you very much.

@ito-san
Copy link
Contributor

ito-san commented Jan 6, 2025

@kobayu858 Is there any linked ticket or slack thread? Was traffic_reader_main.cpp not detected?

@kobayu858
Copy link
Contributor Author

@ito-san
The associated slack is here.
One of these tasks is this PR.
No similar error was detected from traffic_reader_main.cpp.

Copy link
Contributor

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kobayu858 kobayu858 merged commit 3aa84a0 into autowarefoundation:main Jan 7, 2025
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants