fix(static_avoidance): add optional check #9782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
zulfaqar-azmi-t4
requested review from
rej55,
go-sakayori,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
TakaHoribe,
TomohitoAndo,
tkimura4 and
yhisaki
as code owners
github-actions
bot
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
yhisaki
approved these changes
Dec 25, 2024
go-sakayori
approved these changes
Dec 25, 2024
There was a problem hiding this comment.
@zulfaqar-azmi-t4 Thank you very much.
Should have noticed it when I reviewed the previous PR...
zulfaqar-azmi-t4
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9782 +/- ##
==========================================
- Coverage 29.66% 29.66% -0.01%
==========================================
Files 1450 1453 +3
Lines 108833 108854 +21
Branches 42740 42740
==========================================
+ Hits 32285 32290 +5
- Misses 73375 73392 +17
+ Partials 3173 3172 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zulfaqar-azmi-t4
merged commit aaad09f
into
autowarefoundation:main
48 of 52 checks passed
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Dec 27, 2024
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds missing optional check for red_signal.
Fix #9701
Related links
Parent Issue:
How was this PR tested?
https://evaluation.tier4.jp/evaluation/reports/faee1737-fe4c-5005-9bf3-f01eabd33f56?project_id=prd_jt
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.