Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(lane_change): explaining cancel and abort process #9845

Merged
merged 18 commits into from
Jan 10, 2025
Merged

docs(lane_change): explaining cancel and abort process #9845

merged 18 commits into from
Jan 10, 2025

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

Description

Enrich description of cancel/abort process.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jan 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Jan 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-9845/
Modified URLs:

@zulfaqar-azmi-t4
docs(lane_change): explaining cancel and abort process
6973b6e 
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4
slight fix in formatting
6989e01 
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4
rephrase sentence
c6546f0 
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4
rephrase and replace image for cancel
3738b9e 
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4
Cancel explanations and limitations
2b779db 
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4
revise abort figure
c393079 
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4
revise flow chart
3e3ea99 
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4
rephase sentence
83de167 
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4
minor fix
5d8a7ef 
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4
finish up
c172c8c 
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4
offers change to reduces for negative connotation
efb8e4b 
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 marked this pull request as ready for review January 9, 2025 08:13
@zulfaqar-azmi-t4
minor fix
ae339c2 
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4
move limitation all the way down
156799b 
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4
precommit
eb8233a 
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4
equation mistake
0dabb51 
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
zulfaqar-azmi-t4 and others added 2 commits January 9, 2025 19:22
@zulfaqar-azmi-t4 @maxime-clem
Update planning/behavior_path_planner/autoware_behavior_path_lane_cha…
f273586 
…nge_module/README.md

Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>
@zulfaqar-azmi-t4 @maxime-clem
Update planning/behavior_path_planner/autoware_behavior_path_lane_cha…
b37d799 
…nge_module/README.md

Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>
@zulfaqar-azmi-t4
rename subheading
0b30882 
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 10, 2025
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 enabled auto-merge (squash) January 10, 2025 08:59
@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.76%. Comparing base (9ce874c) to head (0b30882).
Report is 29 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9845      +/-   ##
==========================================
+ Coverage   29.70%   29.76%   +0.06%     
==========================================
  Files        1453     1455       +2     
  Lines      109015   108795     -220     
  Branches    42605    42432     -173     
==========================================
+ Hits        32379    32381       +2     
+ Misses      73467    73246     -221     
+ Partials     3169     3168       -1
Flag Coverage Δ *Carryforward flag
differential 20.83% <ø> (?)
total 29.76% <ø> (+0.06%) ⬆️ Carriedforward from 9ce874c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 7d63242 into autowarefoundation:main Jan 10, 2025
45 of 46 checks passed
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the docs-lane-change-abort branch January 10, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-clem maxime-clem maxime-clem approved these changes

@mkquda mkquda mkquda approved these changes

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo TomohitoAndo is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

Assignees

@maxime-clem maxime-clem

@mkquda mkquda

Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Software Working Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zulfaqar-azmi-t4 @maxime-clem @mkquda