feat(autoware_utils_pcl): split package #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
isamu-takagi
requested review from
JianKangEgon,
esteve,
mitsudome-r and
youtalk
as code owners
mitsudome-r
reviewed
Feb 21, 2025
autoware_utils/include/autoware_utils/ros/transform_listener.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
esteve
requested changes
Feb 24, 2025
|
@isamu-takagi overall it looks good, just some minor feedback about copyright notices. Thanks! |
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#34
Split out the part related to
PCLfromautoware_utils. Also the minimumtf2part for it asautoware_utils_geometry.How was this PR tested?
Check that the build of autoware core and universe passes
Notes for reviewers
None.
Effects on system behavior
None.