Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add selectable lookup time for dynamic transform #50

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

badai-nguyen
Copy link

@badai-nguyen badai-nguyen commented Mar 17, 2025

Description

How was this PR tested?

Notes for reviewers

None.

Effects on system behavior

None.

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Copy link

github-actions bot commented Mar 17, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen badai-nguyen requested a review from amadeuszsz March 18, 2025 02:06
@badai-nguyen badai-nguyen self-assigned this Mar 18, 2025
@badai-nguyen badai-nguyen marked this pull request as ready for review March 18, 2025 02:23
Copy link

@amadeuszsz amadeuszsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for detailed investigation!

I think we should make time stamp as a required argument, rather than assigning 0 implicitly. We did it before for simplification.

Could you make it as a required argument for all calls? 🙏🏻
I already made quick refactor to figure out design, you can copy it and check if it solves your issue.
Packages in universe will need simple change to e.g.

managed_tf_buffer_->transform_pointcloud(
    in_target_frame, in_cloud_ptr->header.stamp, rclcpp::Duration::from_seconds(1.0), *in_cloud_ptr,  *out_cloud_ptr, true);

From API point of view, I think "stamp overriding" argument is more suitable in call rather than constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants