Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_utils): update readme as deprecated #51

Conversation

isamu-takagi
Copy link
Contributor

Description

#34
Update autoware_utils readme as deprecated package.

How was this PR tested?

Check that the build of autoware core and universe passes.

Notes for reviewers

None.

Effects on system behavior

None.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Copy link

github-actions bot commented Mar 18, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@isamu-takagi isamu-takagi self-assigned this Mar 18, 2025
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isamu-takagi isamu-takagi marked this pull request as draft March 18, 2025 13:20
@isamu-takagi
Copy link
Contributor Author

I found the obsolete test codes here. Could you also remove them?
https://github.com/isamu-takagi/autoware_utils/tree/feat/split-autoware-utils-readme/autoware_utils/test/src

@youtalk This directory is still used by file(GLOB_RECURSE test_files test/*.cpp), I'll move it to split packages.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi marked this pull request as ready for review March 19, 2025 12:07
@isamu-takagi isamu-takagi requested a review from youtalk March 19, 2025 12:07
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi merged commit ab28312 into autowarefoundation:main Mar 19, 2025
9 of 10 checks passed
@isamu-takagi isamu-takagi deleted the feat/split-autoware-utils-readme branch March 19, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants