fix(autoware_utils_geometry): remove reference to hull_graham_andrew to build on Ubuntu Noble #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
sloretz
requested review from
JianKangEgon,
esteve,
isamu-takagi,
mitsudome-r and
youtalk
as code owners
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
sloretz
changed the title
sloretz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Call the non-strategy version of
boost::geometry::convex_hull()for compatibility with newer versions of boost, specifically the one on Ubuntu Noble.How was this PR tested?
I built it on Ubuntu Noble with ament/ament_cmake#571
Notes for reviewers
The
graham_andrewstrategy was explicitly removed from Boost's API (boostorg/geometry@1c9e193). It looks like the code is still used it internally from thedetailnamespace, but it's no longer a public API.Effects on system behavior
I wouldn't expect any, but I'm out of my expertise here.
Could probably apply the same fix to autowarefoundation/autoware_universe#8982