Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package_xml): added autoware_ prefix to gnss_poser #4

Conversation

TaikiYamada4
Copy link

@TaikiYamada4 TaikiYamada4 commented Aug 2, 2024

Description

Following the movement of adding autoware_ prefix to package names, this PR adds autoware prefix to gnss_poser.

Related links

Since this PR strongly relates to sensor launching systems, this PR must be merged together with the following PRs.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Copy link

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TaikiYamada4
Copy link
Author

@mitsudome-r @xmfcx

May I ask who the reviewers are that I need to get approval from?
Or should I merge relevant PRs in other repositories and skip this one?

@TaikiYamada4
Copy link
Author

@mitsudome-r @xmfcx
This is just a friendly ping.
Do Autoware developers have to keep the awsim_labs_sensor_kit_launch in touch when relevant changes occur?

@TaikiYamada4
Copy link
Author

@mitsudome-r @xmfcx
Friendly ping. Could answer these questions above please?

Copy link

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TaikiYamada4 Thanks for this PR. We are glad you made this update. Sorry for the late review.

You can keep updating this repository with the changes.

Unlike the upstream AWSIM, AWSIM Labs aims to work with the latest main Autoware.

@xmfcx xmfcx merged commit dbce284 into autowarefoundation:main Aug 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants