Cargo fmt

tracing-modality/src/common/ingest.rs

@@ -341,7 +341,7 @@ impl ModalityIngest {
 
                 // And return the timeline
                 timeline_id
-            },
+            }
         };
 
         // TODO(AJM): DO LRU EVICTION HERE!
@@ -365,7 +365,8 @@ impl ModalityIngest {
         } = message;
 
         // Ensure that the user reported timeline ID is active.
-        self.bind_user_timeline(timeline_name, user_timeline_id).await?;
+        self.bind_user_timeline(timeline_name, user_timeline_id)
+            .await?;
 
         match message {
             Message::NewSpan {

tracing-modality/src/common/layer.rs

@@ -1,7 +1,7 @@
 use crate::ingest::TimelineId;
 
 use crate::ingest::WrappedMessage;
-use crate::{ingest, TIMELINE_IDENTIFIER, UserTimelineInfo};
+use crate::{ingest, UserTimelineInfo, TIMELINE_IDENTIFIER};
 
 use duplicate::duplicate_item;
 use once_cell::sync::Lazy;

tracing-modality/src/common/mod.rs

@@ -6,7 +6,6 @@ pub(crate) mod options;
 use crate::Options;
 use ingest::ConnectError;
 use once_cell::sync::OnceCell;
-use uuid::Uuid;
 use std::fmt::Debug;
 use thiserror::Error;
 
@@ -41,13 +40,6 @@ impl UserTimelineInfo {
 // time.
 pub(crate) static TIMELINE_IDENTIFIER: OnceCell<fn() -> UserTimelineInfo> = OnceCell::new();
 
-// TODO(AJM): Probably combine this with TIMELINE_IDENTIFIER to make a single "OnceConfig"
-// that we can use/reuse without having to grab multiple OnceCells
-//
-// That being said - this is randomly generated by us, so this *could* be a Lazy instead of
-// a OnceCell, but that's probably more of a preference thing.
-pub(crate) static RUN_ID: OnceCell<Uuid> = OnceCell::new();
-
 #[derive(Debug, Error)]
 pub enum InitError {
     /// No auth was provided, set with

tracing-modality/src/common/options.rs

@@ -1,11 +1,11 @@
 use crate::UserTimelineInfo;
 use modality_ingest_client::types::AttrVal;
-use std::net::SocketAddr;
 use once_cell::sync::Lazy;
 use std::collections::hash_map::DefaultHasher;
+use std::hash::Hash;
 use std::hash::Hasher;
+use std::net::SocketAddr;
 use std::thread;
-use std::hash::Hash;
 
 thread_local! {
     static THREAD_TIMELINE_INFO: Lazy<UserTimelineInfo> = Lazy::new(|| {
@@ -24,7 +24,7 @@ thread_local! {
         // alternatives would be:
         //
         // * To write a fake hasher function, that exfiltrates the underlying value
-        // * To use a "weaker" hash function than SipHash
+        // * To use a "weaker" hash function than SipHash, such as `rustc_hash::FxHasher`
         //
         // In practice, this only happens once per thread, so the actual impact is negligible,
         // and is acceptable for now, particularly as this is already the hasher used for

tracing-modality/src/lib.rs

@@ -3,8 +3,6 @@
 // (almost) always be called from
 #![allow(clippy::needless_doctest_main)]
 #![warn(clippy::all)]
-
-
 // TODO(AJM): removeme
 #![allow(unused_variables, dead_code)]