Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data visualization fixed for postman #2116

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Data visualization fixed for postman #2116

wants to merge 3 commits into from

Conversation

alejandro99so
Copy link
Contributor

video fixed for postman documentation

@alejandro99so alejandro99so requested review from amandamarquis1 and a team as code owners February 23, 2025 04:33
@vercel Vercel
Copy link

vercel bot commented Feb 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builders-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 4:59am
l1-toolbox ❌ Failed (Inspect) 💬 Add feedback Feb 26, 2025 4:59am

@alejandro99so alejandro99so mentioned this pull request Feb 23, 2025
Open
@martineckardt
Copy link
Collaborator

Can you check if you can replace the iframes with the YouTube component?

<YouTube id="3cAFxV2AIU8" />

martineckardt
martineckardt requested changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@martineckardt martineckardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace iframes with YouTube component

@alejandro99so
Copy link
Contributor Author

For App Router the best way to load and display a youtube video is through:

https://nextjs.org/docs/app/building-your-application/optimizing/third-party-libraries#youtube-embed

due to it is using: lite-youtube-embed

In the file:
https://github.com/ava-labs/avalanche-docs/blob/master/content/docs/tooling/avalanche-postman/making-api-calls.mdx
"C-Chain Public API Call" was using an incorrect Id, it was replaced by the correct, in order to call "eth getTransactionByHash": M83WhbXq5R0

@alejandro99so
Copy link
Contributor Author

alejandro99so commented Feb 25, 2025 •
edited
Loading

With that update, I suggest to replace:
https://github.com/ava-labs/avalanche-docs/blob/master/components/content-design/youtube.tsx
with a variant of the new "youtube-player" file in the same path:
https://github.com/ava-labs/avalanche-docs/blob/master/components/content-design/youtube-player.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martineckardt martineckardt martineckardt requested changes

@amandamarquis1 amandamarquis1 Awaiting requested review from amandamarquis1 amandamarquis1 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alejandro99so @martineckardt