Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Federiconardelli7/issue2068 remote content loading #2119

Merged

Conversation

federiconardelli7
Copy link
Contributor

remote-content.mts file updated to remote fetch files.

this one: https://github.com/ava-labs/avalanchego/blob/master/api/keystore/
is not included because it's now deleted.

Copy link

vercel bot commented Feb 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builders-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 2:33pm
l1-toolbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 2:33pm

@meaghanfitzgerald
Copy link
Collaborator

is the remote-content script removing the unused metadata from the files in avalanchego or did you manually changed the pulled content within this PR?
I.e. This page ideally needs the unused metadata (lines 1-6) removed from the file in avalanchego, however it looks like it was already removed.

@federiconardelli7
Copy link
Contributor Author

The remote-content script removed the unused metadata (lines 1-6). I updated the MDX transformation to fetch the data correctly, and added missing entries for files that weren't being remote fetched before. For example, the page at https://build.avax.network/docs/nodes/configure/configs-flags is now fetched like this https://builders-hub-git-federiconardelli7-issue2068-re-a93c24-ava-labs.vercel.app/docs/nodes/configure/configs-flags

@martineckardt martineckardt merged commit 647c8ba into master Feb 25, 2025
3 of 4 checks passed
@meaghanfitzgerald
Copy link
Collaborator

The page @federiconardelli7 mentioned has 2 title lines and 2 subtitles: https://build.avax.network/docs/nodes/configure/configs-flags

@meaghanfitzgerald
Copy link
Collaborator

meaghanfitzgerald commented Feb 25, 2025

My earlier comment mentions that the existing metadata must be removed to avoid this duplicative issue. Please raise a PR directly in avalanchego for this and check that the other pages pulled remotely in the docs do not have the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote content loading
3 participants