Skip to content

Commit 354a3f4

Browse files
authored
[HWORKS-731] Raise error if deployment cannot be created (logicalclocks#199)
1 parent 43be7fc commit 354a3f4

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

python/hsml/engine/serving_engine.py

+5-1
Original file line numberDiff line numberDiff line change
@@ -402,6 +402,7 @@ def create(self, deployment_instance):
402402
self._serving_api.put(deployment_instance)
403403
print("Deployment created, explore it at " + deployment_instance.get_url())
404404
except RestAPIError as re:
405+
raise_err = True
405406
if re.error_code == ModelServingException.ERROR_CODE_DUPLICATED_ENTRY:
406407
msg = "Deployment with the same name already exists"
407408
existing_deployment = self._serving_api.get(deployment_instance.name)
@@ -415,10 +416,13 @@ def create(self, deployment_instance):
415416
deployment_instance.update_from_response_json(
416417
existing_deployment.to_dict()
417418
)
419+
raise_err = False
418420
else: # otherwise, raise an exception
419421
print(", but it is serving a different model version.")
420422
print("Please, choose a different name.")
421-
raise re
423+
424+
if raise_err:
425+
raise re
422426

423427
if deployment_instance.is_stopped():
424428
print("Before making predictions, start the deployment by using `.start()`")

0 commit comments

Comments
 (0)