Skip to content

Commit eee4f5b

Browse files
authored
[HWORKS-798] Add **kwargs to python client libraries (logicalclocks#205)
1 parent 784b0b5 commit eee4f5b

24 files changed

+35
-11
lines changed

python/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@
1212
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1313
# See the License for the specific language governing permissions and
1414
# limitations under the License.
15-
#
15+
#

python/hsml/deployable_component.py

+1
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ def __init__(
3333
script_file: Optional[str] = None,
3434
resources: Optional[Resources] = None,
3535
inference_batcher: Optional[Union[InferenceBatcher, dict]] = None,
36+
**kwargs,
3637
):
3738
self._script_file = script_file
3839
self._resources = resources

python/hsml/deployable_component_logs.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ class DeployableComponentLogs:
2929
`DeployableComponentLogs`. Server logs of a deployable component
3030
"""
3131

32-
def __init__(self, instance_name: str, content: str):
32+
def __init__(self, instance_name: str, content: str, **kwargs):
3333
self._instance_name = instance_name
3434
self._content = content
3535
self._created_at = datetime.now()

python/hsml/deployment.py

+5-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,11 @@ class Deployment:
3434
"""Metadata object representing a deployment in Model Serving."""
3535

3636
def __init__(
37-
self, predictor, name: Optional[str] = None, description: Optional[str] = None
37+
self,
38+
predictor,
39+
name: Optional[str] = None,
40+
description: Optional[str] = None,
41+
**kwargs,
3842
):
3943
self._predictor = predictor
4044
self._description = description

python/hsml/inference_batcher.py

+1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ def __init__(
4040
max_batch_size: Optional[int] = None,
4141
max_latency: Optional[int] = None,
4242
timeout: Optional[int] = None,
43+
**kwargs,
4344
):
4445
self._enabled = enabled if enabled is not None else INFERENCE_BATCHER.ENABLED
4546
self._max_batch_size = max_batch_size if max_batch_size is not None else None

python/hsml/inference_endpoint.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class InferenceEndpointPort:
3030
`InferenceEndpointPort`. Port of an inference endpoint.
3131
"""
3232

33-
def __init__(self, name: str, number: int):
33+
def __init__(self, name: str, number: int, **kwargs):
3434
self._name = name
3535
self._number = number
3636

python/hsml/inference_logger.py

+1
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ def __init__(
3737
self,
3838
kafka_topic: Optional[Union[KafkaTopic, dict]] = DEFAULT,
3939
mode: Optional[str] = INFERENCE_LOGGER.MODE_ALL,
40+
**kwargs,
4041
):
4142
self._kafka_topic = util.get_obj_from_json(kafka_topic, KafkaTopic)
4243
self._mode = self._validate_mode(mode) or (

python/hsml/kafka_topic.py

+1
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ def __init__(
2929
name: str = KAFKA_TOPIC.CREATE,
3030
num_replicas: Optional[int] = None,
3131
num_partitions: Optional[int] = None,
32+
**kwargs,
3233
):
3334
self._name = name
3435
self._num_replicas, self._num_partitions = self._validate_topic_config(

python/hsml/model.py

+1
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ def __init__(
5151
input_example=None,
5252
framework=None,
5353
model_registry_id=None,
54+
**kwargs,
5455
):
5556
self._id = id
5657
self._name = name

python/hsml/model_registry.py

+1
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ def __init__(
3434
project_id,
3535
model_registry_id,
3636
shared_registry_project_name=None,
37+
**kwargs,
3738
):
3839
self._project_name = project_name
3940
self._project_id = project_id

python/hsml/model_schema.py

+1
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ def __init__(
3535
self,
3636
input_schema: Optional[Schema] = None,
3737
output_schema: Optional[Schema] = None,
38+
**kwargs,
3839
):
3940
if input_schema is not None:
4041
self.input_schema = input_schema

python/hsml/model_serving.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,12 @@
3232
class ModelServing:
3333
DEFAULT_VERSION = 1
3434

35-
def __init__(self, project_name: str, project_id: int):
35+
def __init__(
36+
self,
37+
project_name: str,
38+
project_id: int,
39+
**kwargs,
40+
):
3641
self._project_name = project_name
3742
self._project_id = project_id
3843

python/hsml/predictor.py

+1
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ def __init__(
5252
description: Optional[str] = None,
5353
created_at: Optional[str] = None,
5454
creator: Optional[str] = None,
55+
**kwargs,
5556
):
5657
serving_tool = (
5758
self._validate_serving_tool(serving_tool)

python/hsml/predictor_state.py

+1
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ def __init__(
3434
deployed: Optional[bool],
3535
condition: Optional[PredictorStateCondition],
3636
status: str,
37+
**kwargs,
3738
):
3839
self._available_predictor_instances = available_predictor_instances
3940
self._available_transformer_instances = available_transformer_instances

python/hsml/predictor_state_condition.py

+1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ def __init__(
2828
type: str,
2929
status: Optional[bool] = None,
3030
reason: Optional[str] = None,
31+
**kwargs,
3132
):
3233
self._type = type
3334
self._status = status

python/hsml/python/model.py

+1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ def __init__(
4040
training_dataset=None,
4141
input_example=None,
4242
model_registry_id=None,
43+
**kwargs,
4344
):
4445
super().__init__(
4546
id,

python/hsml/resources.py

+1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ def __init__(
4040
cores: int,
4141
memory: int,
4242
gpus: int,
43+
**kwargs,
4344
):
4445
self._cores = cores
4546
self._memory = memory

python/hsml/schema.py

+1
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ def __init__(
4444
list,
4545
]
4646
] = None,
47+
**kwargs,
4748
):
4849
# A tensor schema is either ndarray of a list containing name, type and shape dicts
4950
if isinstance(object, numpy.ndarray) or (

python/hsml/sklearn/model.py

+1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ def __init__(
4040
training_dataset=None,
4141
input_example=None,
4242
model_registry_id=None,
43+
**kwargs,
4344
):
4445
super().__init__(
4546
id,

python/hsml/tag.py

+1
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ def __init__(
3131
items=None,
3232
count=None,
3333
type=None,
34+
**kwargs,
3435
):
3536
self._name = name
3637
self._value = value

python/hsml/tensorflow/model.py

+1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ def __init__(
4040
training_dataset=None,
4141
input_example=None,
4242
model_registry_id=None,
43+
**kwargs,
4344
):
4445
super().__init__(
4546
id,

python/hsml/torch/model.py

+1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ def __init__(
4040
training_dataset=None,
4141
input_example=None,
4242
model_registry_id=None,
43+
**kwargs,
4344
):
4445
super().__init__(
4546
id,

python/hsml/transformer.py

+1
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ def __init__(
3030
self,
3131
script_file: str,
3232
resources: Optional[Union[TransformerResources, dict]] = None, # base
33+
**kwargs,
3334
):
3435
resources = (
3536
self._validate_resources(

python/setup.py

+3-6
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,10 @@ def read(fname):
4040
"numpy",
4141
"pyjks",
4242
"mock",
43-
"tqdm"
43+
"tqdm",
4444
],
4545
extras_require={
46-
"dev": [
47-
"pytest",
48-
"flake8",
49-
"black"],
46+
"dev": ["pytest", "flake8", "black"],
5047
"docs": [
5148
"mkdocs==1.3.0",
5249
"mkdocs-material==8.2.8",
@@ -56,7 +53,7 @@ def read(fname):
5653
"markdown-include",
5754
"markdown==3.3.7",
5855
"pymdown-extensions",
59-
]
56+
],
6057
},
6158
author="Logical Clocks AB",
6259
author_email="robin@logicalclocks.com",

0 commit comments

Comments
 (0)