Test #1
Closed
Test #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Decamelize dict to pass correct args * Fix id in from_ge_type * Added ids to dict for conversions * allow extra kwargs
…save method (#1060)
* return type for get_feature_vector
…eate (#1071) * init * fix tests
* add serving key to fv * remove redundant variable * address comment
* added snowflake flyingduck support * small fixes * restructured query object * formatting * fixed filter column name for pushdown * provide default argument for fg_aliases * add connectors to test * added tests for snowflake connector * added strip_featurestore_name to util * print regular error message if external fg not supported by fd * addressed comments * removed printline
Co-authored-by: Fabio Buso <buso.fabio@gmail.com>
…… (#1080) * [FSTORE-963] feature group expectation_suite setter doesn't handle properly ExpectationSuite type objects * Update asserts
…for path connectors (#1070)
… (#1086) * added afs create train data wtihout tf * format * support for create_training_data * only when no splits and not tf * updated docs * added loading animation * only call for parquet format * use get(value)
* init batch scoring fail over * add comment
Beam support for java client
* added bigquery arrow flight storage connector * udpated comment * removed comment * addressed comments * added remove semicolon from query * removed quote
* added asof join * added to_string option for arrow_flight * added read options to external featuregroup * removed read_options again
* get_env * add to __all__ * add doc * rename
…f missing on pre-check (#1339) * If a feature is a label, then no need to fail if missing on pre-check * Fix * Do not handle complex features if rest client * Fix condition
…of materialization job (#1337)
…from 3.8 (#1338) * remove min_score * remove min_score doc
… getting FG (#1340) * init * minor fixes * execute check in the api * add checks to python get fg api * move check features to api * ruff fix * fg test fix * improve warning * update warning * fix java lint * fix java * fix lint
…aStreamer (#1345)
… a profile in hsfs (#1351)
… a profile in hsfs (logicalclocks#239)
* init-working * add lock changes * move lock to execute method * update lock * pass pool as arg * loop changes and refactoring * make new connection pool for each call * make exec_prep async and add lock * use context manager and refactor init connection * use create task * add semaphore * remove nest_async and use manual loop * make nest asyncio only if jupyter * refactoring and move hostname retrieving to init serving * minor clean * minor cleanup * add unit test * remove return of pool * revert locust changes and refactoring * revert locust changes and refactoring * fix review comments * fix review comments * remove loop method argument --------- Co-authored-by: Victor Jouffrey <37411285+vatj@users.noreply.github.com>
It was impure, changing environ variable and thereby messing other tests. This commit wraps these tests in a decorator saving and restoring os.environ.
The tests run fine locally, but fail in GitHub Actions. Maybe the problem is in IO mocking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.