Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: media library/gallery #3561

Merged
merged 31 commits into from
Jan 30, 2025
Merged

feature: media library/gallery #3561

merged 31 commits into from
Jan 30, 2025

Conversation

adrianthedev
Copy link
Collaborator

@adrianthedev adrianthedev commented Dec 29, 2024

Description

Fixes #2073
Fixes #3527

This PR adds two features:

1. Media Library enables users to browse all the Active Storage attachments and update them.

2. Gallery for Trix and Rhino fields which enables a user to inject attachments in the body of the editor. The user can inject multiple files at once.

Screenshots

  1. Media Library
CleanShot.2024-12-29.at.16.05.01.mp4
  1. WYSIWYG Gallery
CleanShot.2024-12-29.at.16.06.00.mp4

Checklist:

  • I have performed a self-review of my own code
  • Authorization
  • Configuration
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Still to do:

  • settle on controllers
  • make pagination work on field gallery mode
  • Improve modal styling (check if it looks good on field gallery mode)
  • remove the "side-view" for the initial iteration. it was previously implemented but abandoned
  • if attachments are disabled, the media library button is hidden in Trix field. That should be visible IMHO
  • check other types of files (other than images)
    • check the representable support

Second iteration:

  • Add "dropzone" style box to drop files in the gallery
  • add search
  • add filters
  • media library as a field. show it like we show the associations

@adrianthedev adrianthedev added Task Something to get done 😎 Cool labels Dec 29, 2024
Copy link

codeclimate bot commented Dec 29, 2024

Code Climate has analyzed commit 263cd12 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@adrianthedev adrianthedev self-assigned this Jan 8, 2025
adrianthedev and others added 3 commits January 30, 2025 13:49
…as HTML

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@Paul-Bob Paul-Bob marked this pull request as ready for review January 30, 2025 13:52
@Paul-Bob Paul-Bob merged commit 8ed64be into main Jan 30, 2025
19 of 20 checks passed
@Paul-Bob Paul-Bob deleted the feature/media-library branch January 30, 2025 14:12
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😎 Cool Feature Task Something to get done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix avo-rhino_field styles
2 participants