Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: delegate missing to view_context #2314

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Jan 3, 2024

Description

Fixes #2300

Delegating missing methods to view_context on Avo::ExecutionContext allow to direclty use @view_context methods without explicitly call it:

body: simple_format(record.description)

VS

body: view_context.simple_format(record.description)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob requested a review from adrianthedev January 3, 2024 17:02
@Paul-Bob Paul-Bob self-assigned this Jan 3, 2024
Copy link

codeclimate bot commented Jan 3, 2024

Code Climate has analyzed commit a6bd626 and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev adrianthedev merged commit 06390c5 into main Jan 4, 2024
17 checks passed
@adrianthedev adrianthedev deleted the feature/delegate_missing_to_view_context branch January 4, 2024 10:39
Copy link
Contributor

github-actions bot commented Jan 4, 2024

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delegate missign methods to view_context in ExecutionContext
2 participants