Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eject generator failing due to undefined source_location method #3566

Merged
merged 4 commits into from
Jan 7, 2025
Merged

fix: eject generator failing due to undefined source_location method #3566

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d7fd7b6
fix: reject generator failing due to undefined source_location
Eddayy Jan 3, 2025
a86e163
fix: better source locator
Eddayy Jan 3, 2025
cace532
fix: revert const if statement
Eddayy Jan 3, 2025
fc70f6d
Update eject_generator.rb
Eddayy Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/generators/avo/eject_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def eject_component(component_to_eject = options[:component], confirmation: true
# Get the component path for both, the rb and erb files
rb, erb = if (component_constant = component_to_eject.safe_constantize)
# If component is a constant, find the source location
source_location = component_constant.source_location
source_location = component_constant.identifier

[source_location, source_location.gsub(".rb", ".html.erb")]
else
Expand Down
Loading