Merge pull request #304 from richzw/master

takecy · web-flow · commit 195f7cf93774 · 2024-11-15T18:19:42.000+09:00
feat(appstore): change the response of api server from interface to specific response
diff --git a/appstore/api/validator.go b/appstore/api/validator.go
@@ -7,7 +7,7 @@ import (
 
 // IAPAPIClient is an interface to call validation API in App Store Server API
 type IAPAPIClient interface {
-	Verify(ctx context.Context, transactionId string) (interface{}, error)
+	Verify(ctx context.Context, transactionId string) (*TransactionInfoResponse, error)
 }
 
 type APIClient struct {
@@ -23,7 +23,7 @@ func NewAPIClient(config StoreConfig) *APIClient {
 	return &APIClient{productionCli: NewStoreClient(&prodConf), sandboxCli: NewStoreClient(&sandboxConf)}
 }
 
-func (c *APIClient) Verify(ctx context.Context, transactionId string) (interface{}, error) {
+func (c *APIClient) Verify(ctx context.Context, transactionId string) (*TransactionInfoResponse, error) {
 	result, err := c.productionCli.GetTransactionInfo(ctx, transactionId)
 	if err != nil && errors.Is(err, TransactionIdNotFoundError) {
 		result, err = c.sandboxCli.GetTransactionInfo(ctx, transactionId)

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ import (`
`7`	`7`
`8`	`8`	`// IAPAPIClient is an interface to call validation API in App Store Server API`
`9`	`9`	`type IAPAPIClient interface {`
`10`		`- Verify(ctx context.Context, transactionId string) (interface{}, error)`
	`10`	`+ Verify(ctx context.Context, transactionId string) (*TransactionInfoResponse, error)`
`11`	`11`	`}`
`12`	`12`
`13`	`13`	`type APIClient struct {`
`@@ -23,7 +23,7 @@ func NewAPIClient(config StoreConfig) *APIClient {`
`23`	`23`	`return &APIClient{productionCli: NewStoreClient(&prodConf), sandboxCli: NewStoreClient(&sandboxConf)}`
`24`	`24`	`}`
`25`	`25`
`26`		`-func (c *APIClient) Verify(ctx context.Context, transactionId string) (interface{}, error) {`
	`26`	`+func (c APIClient) Verify(ctx context.Context, transactionId string) (TransactionInfoResponse, error) {`
`27`	`27`	`result, err := c.productionCli.GetTransactionInfo(ctx, transactionId)`
`28`	`28`	`if err != nil && errors.Is(err, TransactionIdNotFoundError) {`
`29`	`29`	`result, err = c.sandboxCli.GetTransactionInfo(ctx, transactionId)`