Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

188759960/Add support for log configuration overrides #365

Closed
wants to merge 22 commits into from
Closed

188759960/Add support for log configuration overrides #365

wants to merge 22 commits into from

Conversation

tomage
Copy link

@tomage tomage commented Jan 27, 2025

  • feat: support for setting environment secrets, and other task-def params
  • feat: support for setting environment secrets, and other task-def params (Fix tests)
  • chore: Update dist
  • feat: support for overwriting a placeholder_container_name containe_name
  • feature: overwrite port-mappings and command
  • feature: env-vars
  • Fix inputs
  • Fix
  • Only add env if value is not empty
  • Fix env appending
  • Prefer task def env var
  • log
  • log
  • Add more logging
  • Refactoring env var override and add support for log-config-option override

pierre-wehbe and others added 22 commits November 4, 2022 19:00
@pierre-wehbe
feat: support for setting environment secrets, and other task-def params
eebe842
@pierre-wehbe
feat: support for setting environment secrets, and other task-def par…
3a7d129 
…ams (Fix tests)
@pierre-wehbe
Merge pull request #1 from signos-health/feature/overwrite_param
8974233 
feat: support for setting environment secrets, and other task-def params
chore: Update dist
6e048be
@pierre-wehbe
feat: support for overwriting a placeholder_container_name containe_name
9794c8f
@pierre-wehbe
Merge pull request #2 from signos-health/feature/overwrite_container_…
82fa2da 
…name

feat: support for overwriting a placeholder_container_name containe_name
@pierre-wehbe
feature: overwrite port-mappings and command
8d33226
@pierre-wehbe
Merge pull request #3 from signos-health/feature/overwrite_portmappin…
e26d3e1 
…gs_command

feature: overwrite port-mappings and command
@pierre-wehbe
feature: env-vars
3170d63
@pierre-wehbe
Merge pull request #4 from signos-health/feature/env-files
df6ed35 
feature: env-vars
@pierre-wehbe
Fix inputs
ee38438
@pierre-wehbe
Fix
1ad9f96
@pierre-wehbe
Only add env if value is not empty
fe26c06
@pierre-wehbe
Fix env appending
ee3bd75
@juggy
Prefer task def env var
948ccc2
@juggy
log
eb8eb3a
@juggy
Merge pull request #7 from signos-health/juggy/prefer-task-def-env
b5910b3 
Prefer task def env var
@juggy
log
fc913b8
@juggy
Merge branch 'master' into juggy/prefer-task-def-env
980e3fb
@juggy
Merge pull request #8 from signos-health/juggy/prefer-task-def-env
cd6a1c5 
log
@tomage
Add more logging
252c08d
@tomage
Refactoring env var override and add support for log-config-option ov…
2b0936c 
…erride

Issue: https://www.pivotaltracker.com/n/projects/2688842/stories/188759960
PR: aws-actions#365
@tomage tomage force-pushed the 188759960/Add-support-for-log-configuration-overrides branch from 0104665 to 2b0936c Compare January 27, 2025 22:35
@tomage tomage closed this Jan 27, 2025
@tomage
Copy link
Author

tomage commented Jan 27, 2025

Didn't mean to open this PR - we have our own in-house fork where we're doing some minor changes.

tomage added a commit to signos-health/amazon-ecs-render-task-definition that referenced this pull request Jan 27, 2025
@tomage
Refactoring env var override and add support for log-config-option ov…
efa3d8b 
…erride

Issue: https://www.pivotaltracker.com/n/projects/2688842/stories/188759960
PR: aws-actions#365
tomage added a commit to signos-health/amazon-ecs-render-task-definition that referenced this pull request Jan 27, 2025
@tomage
Refactoring env var override and add support for log-config-option ov…
965c4ae 
…erride

Issue: https://www.pivotaltracker.com/n/projects/2688842/stories/188759960
PR: aws-actions#365
tomage added a commit to signos-health/amazon-ecs-render-task-definition that referenced this pull request Jan 27, 2025
@tomage
Refactoring env var override and add support for log-config-option ov…
feab797 
…erride

Issue: https://www.pivotaltracker.com/n/projects/2688842/stories/188759960
PR: aws-actions#365
tomage added a commit to signos-health/amazon-ecs-render-task-definition that referenced this pull request Jan 28, 2025
@tomage
Refactoring env var override and add support for log-config-option ov…
8e92b72 
…erride

Issue: https://www.pivotaltracker.com/n/projects/2688842/stories/188759960
PR: aws-actions#365
tomage added a commit to signos-health/amazon-ecs-render-task-definition that referenced this pull request Jan 28, 2025
@tomage
Refactoring env var override and add support for log-config-option ov…
c003fba 
…erride

Issue: https://www.pivotaltracker.com/n/projects/2688842/stories/188759960
PR: aws-actions#365
tomage added a commit to signos-health/amazon-ecs-render-task-definition that referenced this pull request Jan 28, 2025
@tomage
Refactoring env var override and add support for log-config-option ov…
83a8a04 
…erride

Issue: https://www.pivotaltracker.com/n/projects/2688842/stories/188759960
PR: aws-actions#365
tomage added a commit to signos-health/amazon-ecs-render-task-definition that referenced this pull request Jan 28, 2025
@tomage
Refactoring env var override and add support for log-config-option ov…
9fdf00e 
…erride

Issue: https://www.pivotaltracker.com/n/projects/2688842/stories/188759960
PR: aws-actions#365
tomage added a commit to signos-health/amazon-ecs-render-task-definition that referenced this pull request Jan 28, 2025
@tomage
Refactoring env var override and add support for log-config-option ov…
d3aadf3 
…erride

Issue: https://www.pivotaltracker.com/n/projects/2688842/stories/188759960
PR: aws-actions#365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomage @pierre-wehbe @juggy