Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datastore conflict AutoMerge behaves differently from amplify-android #1308

Closed
HuiSF opened this issue Jul 2, 2021 · 4 comments
Closed

Datastore conflict AutoMerge behaves differently from amplify-android #1308

HuiSF opened this issue Jul 2, 2021 · 4 comments
Labels
bug Something isn't working datastore Issues related to the DataStore category
Milestone

Comments

@HuiSF
Copy link
Member

HuiSF commented Jul 2, 2021

Describe the bug

Original issue amplify-flutter #634

amplify-ios AutoMerge for handling conflict caused by multi-device offline/online syncing behaves differently from amplify-android, where amplify-android seems having the correct behavior.

Detailed description please refer to this comment

Steps To Reproduce

Steps to reproduce the behavior:
1. Run datastore in two iOS simulators, say device A and device B, both have same data
2. Make device A and B both offline
3. Make changes to a piece of data in device A, quit App, then make device A online, reopen the App to publish the update mutation
4. Make changes to the same piece of data in device B, quit App, then make device B online, reopen the App to publish the update mutation

Expected behavior

The update mutation made in device B when it was offline should be merged into DynamoDB after AutoMerge

Amplify Framework Version

1.11.0

Amplify Categories

DataStore

Dependency manager

Cocoapods

Swift version

5

CLI version

5.1.0

Xcode version

12.5.1

Relevant log output

No response

Is this a regression? (i.e. was this working before a version upgrade)

No response

Device

iPhone 12 simulators

iOS Version

iOS 14.5

Specific to simulators

No response

Additional context

No response

@HuiSF HuiSF added the pending-triage Issue is pending triage label Jul 2, 2021
@lawmicha lawmicha added datastore Issues related to the DataStore category follow up Requires follow up from maintainers and removed pending-triage Issue is pending triage labels Jul 8, 2021
@HuiSF
Copy link
Member Author

HuiSF commented Jul 28, 2021

@lawmicha any update on this issue please?

@harsh62 harsh62 added the bug Something isn't working label Mar 28, 2022
@chrisbonifacio
Copy link
Member

@HuiSF sorry the delay, we've triaged the issue and added it to our backlog for improving behavior parity between platforms.

@5d 5d self-assigned this Jun 8, 2023
@thisisabhash thisisabhash added this to the 3.0.0 milestone Aug 4, 2023
@lawmicha lawmicha unassigned 5d Oct 3, 2023
@lawmicha lawmicha added the requires attention Follow up needed for more than 10 days label Oct 3, 2023
@atierian atierian removed the p2 label Oct 16, 2023
@atierian atierian added pending-release Code has been merged but pending release Code has been merged but pending release and removed follow up Requires follow up from maintainers requires attention Follow up needed for more than 10 days labels Dec 8, 2023
@atierian
Copy link
Member

atierian commented Jan 9, 2024

This fix has been released in 2.25.3 and 1.30.6

Thanks for reporting this and for your patience!

@atierian atierian closed this as completed Jan 9, 2024
@github-actions github-actions bot removed the pending-release Code has been merged but pending release Code has been merged but pending release label Jan 9, 2024
Copy link
Contributor

github-actions bot commented Jan 9, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working datastore Issues related to the DataStore category
Projects
None yet
Development

No branches or pull requests

7 participants