-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: resolve swiftlint errors and warnings for Amplify Logging plugin #3448
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## chore/swiftlint_predictions #3448 +/- ##
===============================================================
+ Coverage 67.80% 67.97% +0.17%
===============================================================
Files 1079 1079
Lines 36339 36342 +3
===============================================================
+ Hits 24639 24704 +65
+ Misses 11700 11638 -62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one minor comment
AmplifyPlugins/Logging/Sources/AWSCloudWatchLoggingPlugin/Persistence/LogFile.swift
Show resolved
Hide resolved
* chore: resolve swiftlint errors and warnings in amplify categories and amplify core (#3440) * chore: resolve swiftlint errors * chore: resolve swiftlint warnings * chore: resolve swiftlint errors and warnings for Amplify API plugin (#3441) * chore: resolve swiftlint errors * chore: resolve swiftlint warnings * chore: resolve swiftlint warnings * chore: resolve swiftlint errors and warnings for Amplify Auth plugin (#3442) * chore: resolve swiftlint errors * chore: resolve swiftlint warnings * chore: resolve swiftlint warnings * chore: resolve swiftlint errors and warnings * chore: resolve swiftlint errors and warnings for Amplify Datastore plugin (#3443) * chore: resolve swiftlint errors * chore: resolve swiftlint warnings * chore: resolve swiftlint warnings * chore: resolve swiftlint errors and warnings * chore: resolve swiftlint errors and warnings * chore: resolve swiftlint errors and warnings in Amplify Storage plugin (#3444) * chore: resolve swiftlint errors * chore: resolve swiftlint warnings * chore: resolve swiftlint warnings * chore: resolve swiftlint errors and warnings * chore: resolve swiftlint errors and warnings * chore: resolve swiftlint errors and warnings * chore: resolve swiftlint errors and warnings for Analytics plugin (#3445) * chore: resolve swiftlint errors * chore: resolve swiftlint warnings * chore: resolve swiftlint warnings * chore: resolve swiftlint errors and warnings * chore: resolve swiftlint errors and warnings * chore: resolve swiftlint errors and warnings * chore: resolve swiftlint errors and warnings * chore: resolve swiftlint errors and warnings for Amplify Push Notifications plugin (#3446) * chore: resolve swiftlint errors * chore: resolve swiftlint warnings * chore: resolve swiftlint warnings * chore: resolve swiftlint errors and warnings * chore: resolve swiftlint errors and warnings * chore: resolve swiftlint errors and warnings * chore: resolve swiftlint errors and warnings * chore: resolve swiftlint errors and warnings * chore: resolve swiftlint errors and warnings for Amplify Predictions plugin (#3447) * chore: resolve swiftlint errors * chore: resolve swiftlint warnings * chore: resolve swiftlint warnings * chore: resolve swiftlint errors and warnings * chore: resolve swiftlint errors and warnings * chore: resolve swiftlint errors and warnings * chore: resolve swiftlint errors and warnings * chore: resolve swiftlint errors and warnings * chore: resolve swiftlint errors and warnings * chore: resolve swiftlint errors and warnings for Amplify Logging plugin (#3448) * chore: resolve swiftlint errors * chore: resolve swiftlint warnings * chore: resolve swiftlint warnings * chore: resolve swiftlint errors and warnings * chore: resolve swiftlint errors and warnings * chore: resolve swiftlint errors and warnings * chore: resolve swiftlint errors and warnings * chore: resolve swiftlint errors and warnings * chore: resolve swiftlint errors and warnings * chore: resolve swiftlint errors and warnings * chore: resolve merge conflicts
Issue #
Description
General Checklist
Given When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.