Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolve swiftlint errors and warnings for Amplify Logging plugin #3448

Merged
merged 10 commits into from
Jan 3, 2024

Conversation

phantumcode
Copy link
Contributor

Issue #

Description

  • resolve swiftlint errors and warnings for Amplify Logging plugin
  • only includes code formatting changes, there are no functional code changes

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phantumcode phantumcode requested a review from a team as a code owner January 2, 2024 19:42
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (93690dd) 67.80% compared to head (a059f5c) 67.97%.

Files Patch % Lines
...tion/DefaultRemoteLoggingConstraintsProvider.swift 0.00% 1 Missing ⚠️
...udWatchLoggingPlugin/Persistence/LogRotation.swift 88.88% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                       Coverage Diff                       @@
##           chore/swiftlint_predictions    #3448      +/-   ##
===============================================================
+ Coverage                        67.80%   67.97%   +0.17%     
===============================================================
  Files                             1079     1079              
  Lines                            36339    36342       +3     
===============================================================
+ Hits                             24639    24704      +65     
+ Misses                           11700    11638      -62     
Flag Coverage Δ
API_plugin_unit_test 67.07% <ø> (ø)
AWSPluginsCore 64.13% <ø> (ø)
Amplify 48.10% <ø> (ø)
Analytics_plugin_unit_test 81.16% <ø> (ø)
Auth_plugin_unit_test 78.98% <ø> (+0.01%) ⬆️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 80.88% <ø> (+0.89%) ⬆️
Geo_plugin_unit_test 70.75% <ø> (ø)
Logging_plugin_unit_test 63.34% <87.50%> (+0.11%) ⬆️
Predictions_plugin_unit_test 37.16% <ø> (ø)
PushNotifications_plugin_unit_test 87.13% <ø> (ø)
Storage_plugin_unit_test 77.51% <ø> (ø)
unit_tests 67.97% <87.50%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@thisisabhash thisisabhash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment

Base automatically changed from chore/swiftlint_predictions to chore/swiftlint January 3, 2024 20:42
@phantumcode phantumcode merged commit 8d63625 into chore/swiftlint Jan 3, 2024
72 checks passed
@phantumcode phantumcode deleted the chore/swiftlint_logging branch January 3, 2024 20:42
phantumcode added a commit that referenced this pull request Jan 4, 2024
* chore: resolve swiftlint errors and warnings in amplify categories and amplify core (#3440)

* chore: resolve swiftlint errors

* chore: resolve swiftlint warnings

* chore: resolve swiftlint errors and warnings for Amplify API plugin (#3441)

* chore: resolve swiftlint errors

* chore: resolve swiftlint warnings

* chore: resolve swiftlint warnings

* chore: resolve swiftlint errors and warnings for Amplify Auth plugin (#3442)

* chore: resolve swiftlint errors

* chore: resolve swiftlint warnings

* chore: resolve swiftlint warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings for Amplify Datastore plugin (#3443)

* chore: resolve swiftlint errors

* chore: resolve swiftlint warnings

* chore: resolve swiftlint warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings in Amplify Storage plugin (#3444)

* chore: resolve swiftlint errors

* chore: resolve swiftlint warnings

* chore: resolve swiftlint warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings for Analytics plugin (#3445)

* chore: resolve swiftlint errors

* chore: resolve swiftlint warnings

* chore: resolve swiftlint warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings for Amplify Push Notifications plugin (#3446)

* chore: resolve swiftlint errors

* chore: resolve swiftlint warnings

* chore: resolve swiftlint warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings for Amplify Predictions plugin (#3447)

* chore: resolve swiftlint errors

* chore: resolve swiftlint warnings

* chore: resolve swiftlint warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings for Amplify Logging plugin (#3448)

* chore: resolve swiftlint errors

* chore: resolve swiftlint warnings

* chore: resolve swiftlint warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve merge conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants