Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): adding support for keychain sharing using app groups #3947

Merged
merged 7 commits into from
Feb 25, 2025

Style fixes

4b087b1
Select commit
Loading
Failed to load commit list.
Merged

feat(auth): adding support for keychain sharing using app groups #3947

Style fixes
4b087b1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 13, 2025 in 0s

67.71% (-0.08%) compared to 67d40be

View this Pull Request on Codecov

67.71% (-0.08%) compared to 67d40be

Details

Codecov Report

Attention: Patch coverage is 37.87879% with 82 lines in your changes missing coverage. Please review.

Project coverage is 67.71%. Comparing base (67d40be) to head (4b087b1).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...WSPluginsCore/Keychain/KeychainStoreMigrator.swift 0.00% 38 Missing ⚠️
...dentialStorage/AWSCognitoAuthCredentialStore.swift 58.00% 21 Missing ⚠️
Amplify/Categories/Auth/Models/AccessGroup.swift 0.00% 13 Missing ⚠️
...s/Core/AWSPluginsCore/Keychain/KeychainStore.swift 0.00% 6 Missing ⚠️
...gnitoAuthPlugin/Task/AWSAuthFetchSessionTask.swift 55.55% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3947      +/-   ##
==========================================
- Coverage   67.79%   67.71%   -0.08%     
==========================================
  Files        1125     1128       +3     
  Lines       52126    52244     +118     
==========================================
+ Hits        35337    35377      +40     
- Misses      16789    16867      +78

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov