Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for email mfa #94

Merged
merged 35 commits into from
Oct 31, 2024
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
9faafb5
add support for email mfa code
harsh62 Sep 10, 2024
0b859e0
adding support for mfa setup selection and setting up email
harsh62 Sep 10, 2024
b00f24b
Apply suggestions from code review
harsh62 Sep 13, 2024
c0cf3c1
worked on review comments
harsh62 Sep 17, 2024
b8a60ad
update strings and some logics
harsh62 Sep 26, 2024
7aaee26
missed update
harsh62 Sep 26, 2024
9e3c844
Merge branch 'main' into feat/email-mfa
harsh62 Sep 26, 2024
482fbdd
fix conflicts
harsh62 Sep 26, 2024
b855272
pushing a test.
harsh62 Sep 27, 2024
3b4e8ce
update sign in step to confirmSignInWithOTP
harsh62 Oct 15, 2024
e59b4a1
Update Sources/Authenticator/Views/ConfirmSignInWithOTPView.swift
harsh62 Oct 29, 2024
4fcb712
Update Sources/Authenticator/Views/ConfirmSignInWithOTPView.swift
harsh62 Oct 29, 2024
b864f8c
Update Sources/Authenticator/Views/ConfirmSignInWithOTPView.swift
harsh62 Oct 29, 2024
08fb4e5
worked on review comment
harsh62 Oct 30, 2024
e7d458f
updated to match Android
harsh62 Oct 30, 2024
6ae18a5
fix failing tests
harsh62 Oct 30, 2024
524cc99
add/update UI Tests and snapshot images
harsh62 Oct 30, 2024
43f3ec8
trying out ui tests
harsh62 Oct 30, 2024
d06db62
update
harsh62 Oct 30, 2024
cd6c328
missing added file
harsh62 Oct 30, 2024
4d99f42
adding ui tests for next steps
harsh62 Oct 30, 2024
9727af3
revert the package swift for release
harsh62 Oct 30, 2024
40ffa8e
Update Sources/Authenticator/Views/Internal/ConfirmSignInWithCodeView…
sebaland Oct 30, 2024
9f540ad
Update Sources/Authenticator/Views/Internal/ConfirmSignInWithCodeView…
sebaland Oct 30, 2024
b4b4668
Update Sources/Authenticator/Views/Internal/ConfirmSignInWithCodeView…
sebaland Oct 30, 2024
c3bfde4
Update Sources/Authenticator/Views/Internal/ConfirmSignInWithCodeView…
sebaland Oct 30, 2024
a6e90ed
update workflow to get the the latest package dependencies
harsh62 Oct 31, 2024
b992c8f
Merge branch 'feat/email-mfa' of github.com:aws-amplify/amplify-ui-sw…
harsh62 Oct 31, 2024
8e150ff
update workflow
harsh62 Oct 31, 2024
6edc916
another update
harsh62 Oct 31, 2024
21d8aff
update
harsh62 Oct 31, 2024
3a8f206
update
harsh62 Oct 31, 2024
7306bb1
update
harsh62 Oct 31, 2024
1286bad
update package.resolved to remove email mfa support branch reference
harsh62 Oct 31, 2024
6880d18
update amplify version dependency
harsh62 Oct 31, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/ui_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,14 @@ jobs:
ui-test-ios:
runs-on: macos-15
steps:
- uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab # v3.5.2
- name: Checkout
uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab # v3.5.2

- name: Resolve and update Swift packages
run: xcodebuild -resolvePackageDependencies -scheme Authenticator

- name: UI test Authenticator on iOS
working-directory: Tests/AuthenticatorHostApp
run: xcodebuild test -scheme AuthenticatorHostApp -sdk 'iphonesimulator' -destination 'platform=iOS Simulator,name=iPhone 16 Pro Max,OS=latest' -derivedDataPath Build/ -clonedSourcePackagesDirPath ~/Library/Developer/Xcode/DerivedData/Authenticator | xcpretty --simple --color --report junit && exit ${PIPESTATUS[0]}
run: |
xcodebuild -resolvePackageDependencies -scheme Authenticator
xcodebuild test -scheme AuthenticatorHostApp -sdk 'iphonesimulator' -destination 'platform=iOS Simulator,name=iPhone 16 Pro Max,OS=latest' -derivedDataPath Build/ -clonedSourcePackagesDirPath ~/Library/Developer/Xcode/DerivedData/Authenticator | xcpretty --simple --color --report junit && exit ${PIPESTATUS[0]}
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,5 @@ amplifyconfiguration.dart
amplify-build-config.json
amplify-gradle-config.json
amplifytools.xcconfig
.secret-*
.secret-*
Tests/AuthenticatorHostApp/AuthenticatorHostApp.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog

## 1.2.0 (2024-10-31)

### Feature
- **Authenticator**: Adding support for Email MFA (#96)

## 1.1.8 (2024-09-20)

### Bug Fixes
Expand Down
8 changes: 4 additions & 4 deletions Package.resolved
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/aws-amplify/amplify-swift",
"state" : {
"branch" : "feat/email-mfa-support-public",
"revision" : "a1432446796b621e1a624ffe58d39150ea705b31"
"revision" : "aef29d1665f9fad1c88fa6a781b8c847913dd7c6",
"version" : "2.44.0"
}
},
{
Expand Down Expand Up @@ -59,8 +59,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-log.git",
"state" : {
"revision" : "e97a6fcb1ab07462881ac165fdbb37f067e205d5",
"version" : "1.5.4"
"revision" : "9cb486020ebf03bfa5b5df985387a14a98744537",
"version" : "1.6.1"
}
}
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@
import Foundation

public class ComponentInformation {
public static let version = "1.1.8"
public static let version = "1.2.0"
public static let name = "amplify-ui-swift-authenticator"
}

This file was deleted.

Loading