Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rationalise bucket creation #211

Merged
merged 2 commits into from
May 17, 2024
Merged

Rationalise bucket creation #211

merged 2 commits into from
May 17, 2024

Conversation

luigidifraiawork
Copy link
Contributor

@luigidifraiawork luigidifraiawork commented May 14, 2024 •
edited
Loading

Description

Shorten S3 bucket names and ensure name uniqueness of the source one within the queue-processing example blueprint.

Motivation and Context

The destination bucket name prefix was too long and the source bucket was created using the input bucket instead of bucket_prefix.

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@luigidifraiawork luigidifraiawork requested a review from a team as a code owner May 14, 2024 11:47
@joozero joozero merged commit 4209232 into aws-ia:main May 17, 2024
24 checks passed
@luigidifraiawork luigidifraiawork deleted the chore/a-few-rationalisations-s3 branch May 20, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joozero joozero joozero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luigidifraiawork @joozero