Skip to content

Commit 74e0b28

Browse files
authored
New build flag: USE_CPU_EXTENSIONS (#328)
**Issue:** Some customers are encountering mysterious crashes in some of these functions. Give them the ability to disable them while we attempt to diagnose the issue. **Description of changes:** Set `-DUSE_CPU_EXTENSIONS=OFF` to disable CPU-specific functions. This build flag is `ON` by default. This feature comes by updating submodule aws-crt-cpp: v0.17.0 -> v0.17.1
1 parent b4d66ad commit 74e0b28

File tree

2 files changed

+20
-1
lines changed

2 files changed

+20
-1
lines changed

.github/workflows/ci.yml

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,15 @@ jobs:
6666
aws s3 cp s3://aws-crt-test-stuff/ci/${{ env.BUILDER_VERSION }}/linux-container-ci.sh ./linux-container-ci.sh && chmod a+x ./linux-container-ci.sh
6767
./linux-container-ci.sh ${{ env.BUILDER_VERSION }} aws-crt-${{ env.LINUX_BASE_IMAGE }} build -p ${{ env.PACKAGE_NAME }} --cmake-extra=-DBYO_CRYPTO=ON skip_samples=1
6868
69+
linux-no-cpu-extensions:
70+
runs-on: ubuntu-latest
71+
steps:
72+
# We can't use the `uses: docker://image` version yet, GitHub lacks authentication for actions -> packages
73+
- name: Build ${{ env.PACKAGE_NAME }}
74+
run: |
75+
aws s3 cp s3://aws-crt-test-stuff/ci/${{ env.BUILDER_VERSION }}/linux-container-ci.sh ./linux-container-ci.sh && chmod a+x ./linux-container-ci.sh
76+
./linux-container-ci.sh ${{ env.BUILDER_VERSION }} aws-crt-${{ env.LINUX_BASE_IMAGE }} build -p ${{ env.PACKAGE_NAME }} --cmake-extra=-DUSE_CPU_EXTENSIONS=OFF
77+
6978
windows-vs16:
7079
runs-on: windows-latest
7180
steps:
@@ -95,6 +104,16 @@ jobs:
95104
python -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder.pyz')"
96105
python builder.pyz build -p ${{ env.PACKAGE_NAME }} --spec=downstream
97106
107+
windows-no-cpu-extensions:
108+
runs-on: windows-latest
109+
steps:
110+
- name: Build ${{ env.PACKAGE_NAME }} + consumers
111+
run: |
112+
md D:\a\work
113+
cd D:\a\work
114+
python -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz', 'builder.pyz')"
115+
python builder.pyz build -p ${{ env.PACKAGE_NAME }} --cmake-extra=-DUSE_CPU_EXTENSIONS=OFF
116+
98117
osx:
99118
runs-on: macos-latest
100119
steps:

0 commit comments

Comments
 (0)