Esbuild nodejs builder

[gojko]

Issue #, if available:

Solves the following issues or makes them obsolete

• Does sam support sym linked node_modules? aws-sam-cli#1446 (bundler supports local symlinks)
• sam build fail with "No such file or directory" for node build aws-sam-cli#1426 (no need for prepacking any more)
• https://github.com/aws/aws-sam-cli/issues/1544 (bundler will exclude dependencies if not included in the entrypoint)
• sam build does not recognise local nodejs projects outside CodeUri aws-sam-cli#2064 (bundler can read outside the code URI as long as it is not running in a docker build)
• Allow to run node_modules binaries from makefile builder aws-sam-cli#2565 (no need for a build script any more to compile tsc)
• Using TypeScript with nodejs runtime aws-sam-cli#2636 (esbuild can directly bundle .ts)
• npm link causes sam local to error aws-sam-cli#756 (no need for claudia pack any more)
• sam-beta-cdk support for typescript lambda functions - aws-lambda-nodejs aws-sam-cli#3033 (esbuild supports typescript directly)

Description of changes:

Support for ESBuild bundler running as part of the Nodejs NPM workflow, providing the following benefits:

1. support for local directory dependencies and NPM7 relative references and sym linked node_modules
2. support for TypeScript transpilation (.ts -> .js)
3. support for minification (smaller bundle sizes)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[falnyr]

@gojko Hi there, is there any update on this? This would be such a great feature for CDK + Typescript Lambda with SAM. 🙏

[gojko]

@falnyr this is waiting on aws people to merge it, @mgrandis will know more

[kellerkind87]

@mgrandis or other aws people is there any forcast / outline / perspective to get this merged soon?

[tostca]

@mgrandis Is there a possibility to get some more information if this PR will be reviewed in the near future?

[falnyr]

Just pinging more AWS folks to see what do we need to make this happen. 🙏

@aahung @mildaniel

[mgrandis]

Yes! So sorry for the late reply!
We are still planning on integrating this, can't give you an exact date but this is on our plate.

[falnyr]

@mgrandis any updates? There are conflicts now as this is ready for almost 3 months now.

[mgrandis]

A few comments to kick things off.
Can you fix the conflicts? We recently released ARM support which made some significant changes to the code base.
Thanks.

[mgrandis]

Can we pass a flag on which we act upon in execute instead of the value that we use.
This way if the value was to change or the way we pass the value to NPM was to change, we would only have to update execute.
The way this is currently done also allows passing any arbitrary value to NPM which I think is not something we want to allow.

[mgrandis]

We use double quotes on our projects " for strings.
Please ensure you have run make pr.

[gojko]

@mgrandis I've lost interest in this and migrated to another solution since this was so long in the pipeline. If you think it's still worth merging, perhaps just take over?

[mgrandis]

Got it, thanks @gojko!
@mildaniel will take this over

[jfuss]

Closing in favor of #307